MineDojo/Voyager

Inventory is not updated after bot successfully get some resource

fredshentu opened this issue · 4 comments

fredshentu commented

Before submitting an issue, make sure you read the FAQ.md

Briefly describe your issue

Inventory always remains empty even the bot has successfully obtained some resource

Please provide your python, nodejs, Minecraft, and Fabric versions here

Computer: apple M2
python: 3.9.17
nodejs: v18.17.1
minecraft: 1.9
fabric: fabric-loader-0.14.18-1.19

[If applicable] Please provide the Minefalyer and Minecraft logs, you can find the log under logs folder

So even with this error, the Minefalyer runs (tested with node index.js and it says Server started on port 3000)
However, the inventory never updates.

Example log:

****Action Agent human message****
Code from the last round:
async function mineWoodLog(bot) {
  // Find a wood log block
  const logBlock = bot.findBlock({
    matching: block => ["oak_log", "birch_log", "spruce_log", "jungle_log", "acacia_log", "dark_oak_log", "mangrove_log"].includes(block.name),
    maxDistance: 32
  });
  if (!logBlock) {
    bot.chat("No wood log found nearby.");
    return;
  }

  // Mine the wood log block
  await mineBlock(bot, logBlock.name, 1);
  bot.chat("Wood log mined.");
}

Execution error: No error

Chat log: Collect finish!
Wood log mined.

Biome: forest

Time: day

Nearby blocks: oak_leaves, oak_log, birch_leaves, birch_log

Nearby entities (nearest to farthest): pig

Health: 20.0/20

Hunger: 20.0/20

Position: x=239.4, y=74.0, z=-239.5

Equipment: [None, None, None, None, None, None]

Inventory (0/36): Empty

Chests: None

Task: Mine 1 wood log

Context: You can mine one of oak, birch, spruce, jungle, acacia, dark oak, or mangrove logs.

Critique: You should mine a log from eit

The bot keeps failing on the first task, but you can see from the log that the bot has mined some log but the later inventory was not updated. I've tried this codebase on both ubuntu && macos, same issue.
I am using the local minecraft launcher.

[If applicable] Please provide the GPT conversations that are printed each round.

...

fredshentu commented 
Server started on port 3000

Render Action Agent system message with 0 skills
****Action Agent human message****
Code from the last round: No code in the first round

Execution error: No error

Chat log: None

Biome:

Time: day

Nearby blocks: sand, dirt, grass_block, fern, grass

Nearby entities (nearest to farthest): turtle

Health: 20.0/20

Hunger: 20.0/20

Position: x=64.5, y=70.0, z=-111.5

Equipment: [None, None, None, None, None, None]

Inventory (0/36): Empty

Chests: None

Task: Mine 1 wood log

Context: You can mine one of oak, birch, spruce, jungle, acacia, dark oak, or mangrove logs.

Critique: None


****Action Agent ai message****
Explain: No explanation needed as this is the first task.

Plan:
1) Find a wood log block (oak, birch, spruce, jungle, acacia, dark oak, or mangrove) using exploreUntil.
2) Mine the wood log block using mineBlock.

Code:
```javascript
async function mineWoodLog(bot) {
  const logNames = ["oak_log", "birch_log", "spruce_log", "jungle_log", "acacia_log", "dark_oak_log", "mangrove_log"];

  // Find a wood log block
  const logBlock = await exploreUntil(bot, new Vec3(1, 0, 1), 60, () => {
    for (const logName of logNames) {
      const log = bot.findBlock({
        matching: mcData.blocksByName[logName].id,
        maxDistance: 32,
      });
      if (log) return log;
    }
    return null;
  });

  if (!logBlock) {
    bot.chat("Could not find a wood log.");
    return;
  }

  // Mine the wood log block
  await mineBlock(bot, logBlock.name);
  bot.chat("Wood log mined.");
}

mineWoodLog(bot);

Recorder message: 114 ticks have elapsed
Recorder message: 1 iteration passed
Critic Agent human message
Biome:

Time: day

Nearby blocks: sand, grass_block, spruce_leaves, dirt, spruce_log, fern, stone, grass

Health: 20.0/20

Hunger: 20.0/20

Position: x=64.5, y=69.0, z=-97.3

Equipment: [None, None, None, None, None, None]

Inventory (0/36): Empty

Chests: None

Task: Mine 1 wood log

Context: You can mine one of oak, birch, spruce, jungle, acacia, dark oak, or mangrove logs.

Critic Agent ai message
{
"reasoning": "You have not provided any information about your inventory after completing the task. Please provide the updated inventory to assess your progress.",
"success": false,
"critique": "Mine 1 wood log and update your inventory with the collected log."
}
Action Agent human message
Code from the last round:
async function mineWoodLog(bot) {
const logNames = ["oak_log", "birch_log", "spruce_log", "jungle_log", "acacia_log", "dark_oak_log", "mangrove_log"];

// Find a wood log block
const logBlock = await exploreUntil(bot, new Vec3(1, 0, 1), 60, () => {
for (const logName of logNames) {
const log = bot.findBlock({
matching: mcData.blocksByName[logName].id,
maxDistance: 32
});
if (log) return log;
}
return null;
});
if (!logBlock) {
bot.chat("Could not find a wood log.");
return;
}

// Mine the wood log block
await mineBlock(bot, logBlock.name);
bot.chat("Wood log mined.");
}

Execution error: No error

Chat log: Explore success.
Collect finish!
Wood log mined.

Biome:

Time: day

Nearby blocks: sand, grass_block, spruce_leaves, dirt, spruce_log, fern, stone, grass

Nearby entities (nearest to farthest): None

Health: 20.0/20

Hunger: 20.0/20

Position: x=64.5, y=69.0, z=-97.3

Equipment: [None, None, None, None, None, None]

Inventory (0/36): Empty

Chests: None

Task: Mine 1 wood log

Context: You can mine one of oak, birch, spruce, jungle, acacia, dark oak, or mangrove logs.

Critique: Mine 1 wood log and update your inventory with the collected log.

Action Agent ai message
Explain: The code successfully mines a wood log, but the inventory is not updated with the collected log.

Plan:

  1. Find a wood log block using exploreUntil.
  2. Mine the wood log block using mineBlock.
  3. Update the inventory with the collected log.

Code:

async function mineWoodLogAndUpdateInventory(bot) {
  const logNames = ["oak_log", "birch_log", "spruce_log", "jungle_log", "acacia_log", "dark_oak_log", "mangrove_log"];

  // Find a wood log block
  const logBlock = await exploreUntil(bot, new Vec3(1, 0, 1), 60, () => {
    for (const logName of logNames) {
      const log = bot.findBlock({
        matching: mcData.blocksByName[logName].id,
        maxDistance: 32
      });
      if (log) return log;
    }
    return null;
  });
  if (!logBlock) {
    bot.chat("Could not find a wood log.");
    return;
  }

  // Mine the wood log block
  await mineBlock(bot, logBlock.name);
  bot.chat("Wood log mined.");

  // Update the inventory with the collected log
  const logItem = mcData.itemsByName[logBlock.name];
  bot.inventory.addItem(logItem.id, 1);
  bot.chat("Inventory updated with the collected log.");
}

Recorder message: 172 ticks have elapsed
Recorder message: 2 iteration passed
Critic Agent: Error occurs Your code:26
bot.inventory.addItem(logItem.id, 1);
bot.inventory.addItem is not a function

Action Agent human message
Code from the last round:
async function mineWoodLogAndUpdateInventory(bot) {
const logNames = ["oak_log", "birch_log", "spruce_log", "jungle_log", "acacia_log", "dark_oak_log", "mangrove_log"];

// Find a wood log block
const logBlock = await exploreUntil(bot, new Vec3(1, 0, 1), 60, () => {
for (const logName of logNames) {
const log = bot.findBlock({
matching: mcData.blocksByName[logName].id,
maxDistance: 32
});
if (log) return log;
}
return null;
});
if (!logBlock) {
bot.chat("Could not find a wood log.");
return;
}

// Mine the wood log block
await mineBlock(bot, logBlock.name);
bot.chat("Wood log mined.");

// Update the inventory with the collected log
const logItem = mcData.itemsByName[logBlock.name];
bot.inventory.addItem(logItem.id, 1);
bot.chat("Inventory updated with the collected log.");
}

Execution error:
Your code:26
bot.inventory.addItem(logItem.id, 1);
bot.inventory.addItem is not a function

Chat log: Explore success.
Collect finish!
Wood log mined.

Biome:

Time: day

Nearby blocks: sand, grass_block, spruce_leaves, dirt, spruce_log, fern, stone, grass

Nearby entities (nearest to farthest): None

Health: 20.0/20

Hunger: 20.0/20

Position: x=64.5, y=69.0, z=-97.3

Equipment: [None, None, None, None, None, None]

Inventory (0/36): Empty

Chests: None

Task: Mine 1 wood log

Context: You can mine one of oak, birch, spruce, jungle, acacia, dark oak, or mangrove logs.

Critique: None


Some other log here
fredshentu commented

Actually, it seems there is just no Inventory in the Creative mode

github-actions commented

This issue is stale because it has been open for 30 days with no activity.

github-actions commented

This issue was closed because it has been inactive for 14 days since being marked as stale.