Add test coverage badge to repo

Question

Add test coverage badge to repo

Closed this issue 3 years ago · 11 comments

MrPowers commented 5 years ago

Is scoverage the best option?

Answer 1 · 2019-05-12T01:21:40.000Z

Not sure it's best but I've been using scoverage for my project and it works fine.

Answer 2 · 2019-05-12T17:59:45.000Z

@manuzhang - thanks, I am going to add this.

Answer 3 · 2019-05-12T19:34:23.000Z

@manuzhang - I added sbt-scoverage and then ran sbt coverage and it didn't seem to generate any output in the target/scoverage-report directory like I expected. And idea what I'm missing here? #83

Answer 4 · 2019-05-13T03:02:39.000Z

Try sbt test coverageReport

Answer 5 · 2019-05-22T09:03:14.000Z

@MrPowers It seems you have some issues with scoverage. Could you provide more info on how to reproduce it ?

Answer 6 · 2019-05-22T21:23:44.000Z

@manuzhang - Here's what I mentioned in the Gitter channel: "I released v0.32.0 and scoverage was causing my downstream CIs to throw this error (when spark-daria was included in other projects): scoverage/sbt-scoverage#228 Super annoying. I set coverageEnabled := false in the spark-daria build.sbt file to fix this and did a v0.32.1 release."

I had to look all over for this message... Forgot about Gitter ;)

Answer 7 · 2019-05-23T05:17:37.000Z

@MrPowers How is spark-daria included ? Is there a way that I can reproduce your issue ?

Answer 8 · 2019-05-26T16:39:08.000Z

@manuzhang - Sorry for the delayed response.

This commit that sets coverageEnabled := true was included in the v0.32.0 release.

You should be able to reproduce this bug by including spark-daria v0.32.0 in a project and then running your test suite. I created a spark-stringmetric branch to demonstrate the issue.

I think it's important to get the test coverage badge on this project. Let me know how we can move this forward ;)

Answer 9 · 2019-05-26T21:11:05.000Z

Weird bug. I bet the coverage enabled in the build file causes all of spark-Daria to be compiled with the test instrumentation. Le dim. 26 mai 2019 à 12:39, Matthew Powers <notifications@github.com> a écrit :

…

@manuzhang <https://github.com/manuzhang> - Sorry for the delayed response. This commit <3a618ac> that sets coverageEnabled := true was included in the v0.32.0 release. You should be able to reproduce this bug by including spark-daria v0.32.0 in a project and then running your test suite. I created a spark-stringmetric branch to demonstrate the issue <MrPowers/spark-stringmetric#6>. I think it's important to get the test coverage badge on this project. Let me know how we can move this forward ;) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#75?email_source=notifications&email_token=ACXK4VZ6SSHFQMG26PCH4G3PXK4KZA5CNFSM4HIXZEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIJIBQ#issuecomment-496014342>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACXK4VY46F3F3FUC23JH2T3PXK4KZANCNFSM4HIXZELQ> .

Answer 10 · 2019-05-27T07:03:27.000Z

@nvander1 Confirmed after checking out the byte code. @MrPowers Did you run sbt clean +spDist after sbt test coverageReport ? It's recommended here to clean things up before publishing

Answer 11 · 2021-02-25T01:52:56.000Z

I'm closing this, but would be happy to add this in the future if anyone wants it / thinks it'd be useful!