Share to Diaspora* inserts "+" instead of spaces in titles

Question

Share to Diaspora* inserts "+" instead of spaces in titles

wazoox opened this issue 5 years ago · 19 comments

This is a behaviour introduced with version 2.0.x. Version 1.3.0 works fine.

Example sharing this page to Diaspora* initializes the windows with the following text:

### New+Issue+·+Mte90/Share-Backported

https://github.com/Mte90/Share-Backported/issues/new

What's expected instead (what happened with version 1.30):

### New Issue · Mte90/Share-Backported

https://github.com/Mte90/Share-Backported/issues/new

Confirmed across several users. Downgrading to 1.3.0 fixes the problem.

Mte90 commented 5 years ago

:-D

Answer 1 · 2019-10-23T09:29:39.000Z

We have a specific code for diaspora but seems that is not executed https://github.com/Mte90/Share-Backported/blob/master/modal/modal.js#L243 I will work on that.

Answer 2 · 2019-10-23T13:37:44.000Z

Thanks for the quick fix friends :)

Answer 3 · 2019-11-02T13:37:01.000Z

Today's update broke Diaspora sharing again :/

Answer 4 · 2019-11-02T13:39:25.000Z

It is this line that create issues, should be on top https://github.com/Mte90/Share-Backported/blob/master/modal/modal.js#L268

Answer 5 · 2019-11-04T17:56:13.000Z

Fixed in the last release

Answer 6 · 2019-11-04T19:54:42.000Z

Sorry, the problem is still there (v. 2.0.6). Tried on two machines, restarted Firefox, no dice. Le lun. 4 nov. 2019 à 18:56, Daniele Scasciafratte <notifications@github.com> a écrit :

…

Closed #117 <#117>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#117?email_source=notifications&email_token=ABIMIGXDEBU52G7RSADGFJDQSBO35A5CNFSM4JDQCG4KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUUDFRNI#event-2768656565>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIMIGXBG7IANIIADZCOGPLQSBO35ANCNFSM4JDQCG4A> .

Answer 7 · 2019-11-04T20:57:19.000Z

Hm, + would be a space in encodeURIComponent …

@Mte90 Let me know, if you need a hand here :-)

Answer 8 · 2019-11-05T13:39:27.000Z

On my tests the url is ok: https://share.diasporafoundation.org/?url=https%3A%2F%2Fdaniele.tech%2Fita%2F&title=Home+-+Daniele+Mte90+Scasciafratte
The encode anyway is happening at the top before do the fixes for the various shares.

Answer 9 · 2019-11-05T13:40:54.000Z

I don't have an account on diaspora to see what is happening

Answer 10 · 2019-11-05T14:08:43.000Z

Here's a screenshot (running the current version):
http://imgur.com/Ap6JoX4l.png

Answer 11 · 2019-11-05T15:02:18.000Z

So seems that diaspora doesn't like + and want them encoded anyway.
It is something that i can do, I will do some tests

Answer 12 · 2019-11-05T15:07:37.000Z

No I found a wrong variable used in diaspora -.-'

Answer 13 · 2019-11-06T17:45:16.000Z

I hereby confirm 2 .0.7 works fine :) Thanks @Mte90 👍

Answer 14 · 2020-12-01T15:13:50.000Z

Hello @Mte90, version 2.1.0 upgrade today just reintroduced this bug!

Answer 15 · 2020-12-02T15:09:48.000Z

Very strange the code is there https://github.com/Mte90/Share-Backported/blob/master/modal/modal.js#L319

I am opening back the ticket to study the situation.

Answer 16 · 2020-12-02T21:34:27.000Z

You could check the latest posts from my friend Jay : https://diasp.eu/people/a0863370a7790131339411719cc2cd82 :) Le mer. 2 déc. 2020 à 16:10, Daniele Scasciafratte <notifications@github.com> a écrit :

…

Very strange the code is there https://github.com/Mte90/Share-Backported/blob/master/modal/modal.js#L319 I am opening back the ticket to study the situation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIMIGWB4AY3RSWG45COIKLSSZKE5ANCNFSM4JDQCG4A> .

Answer 17 · 2020-12-04T18:33:02.000Z

Thanks, I'll check it out! Cheers Emmanuel Le ven. 4 déc. 2020 à 19:21, Daniele Scasciafratte <notifications@github.com> a écrit :

…

Closed #117 <#117> via a0d0264 <a0d0264> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIMIGRIE75TCXBAQBABEF3STESEHANCNFSM4JDQCG4A> .

Answer 18 · 2020-12-04T18:34:44.000Z

There is a new release with a fix, in my tests should be fixed now.