Consider control adoption in the Unity UI Extensions collection?
SimonDarksideJ opened this issue · 5 comments
Hi
One of the users of the Unity UI Extensions project spotted your control and suggested it would be a good for including in the project.
https://bitbucket.org/UnityUIExtensions/unity-ui-extensions
Would you be ok with your control being uplifted there?
hey @SimonDarksideJ,
Sure, that would be awesome. I've used this library before and it would be a honour to have my project there.
Can you do a PR to the project, or would you rather we pulled it over.
My only concern is ensuring it's features are distinct to the existing UIInfiniteScroll (which is only vertical at present), so this might replace it or enhance it.
So long as it works in both blank (no custom data) and in data modes
Later today I will have a look and make a PR, ok?
@SimonDarksideJ , if i'm not mistaken, UIInfiniteScroll doesn't contain object pooling and instead relies on the list objects all being created already... So effectively these are two separate kinds of lists.
Agreed, this would be another ScrollRect Variant, so it is fine to add it as another. Just be sure to set out in the docs what makes this control different so that users understand which to choose.
Unless you feel that there is an existing control that is similar that you could enhance, extend to achieve the same flexibility.
You are correct that the UIInfiniteScroll does not use pooling. It relies on other controls to provide that capability for a more modular approach, such as the Horizontal and Vertical Scroll snaps.