Microphysics always initialized with hydrostatic=.true.

When running without inline microphysics the GFS layer initializes the microphysics by creating a Statein and then passing Statein(1)%dycore_hydrostatic to gfdl_cld_mp_init. The problem with this is that Statein%dycore_hydrostatic is set to .true.` by default and isn't overwritten with the actual model configuration before initializing the microphysics:

SHiELD_physics/GFS_layer/GFS_driver.F90

Line 221 in b285c9d

    
           call gfdl_cld_mp_init (Model%input_nml_file, Init_parm%logunit, Statein(1)%dycore_hydrostatic)

SHiELD_physics/GFS_layer/GFS_typedefs.F90

Line 1361 in b285c9d

Statein%dycore_hydrostatic = .true.

This causes the parameters such as c_air to be set to their hydrostatic values instead of their nonhydrostatic values, and overrides do_sedi_w with .false. regardless of what is in the namelist.

Hi, Oliver. Thanks for filing this issue. A clarification: this effectively means that the "split" GFDL MP always runs with the hydrostatic assumption. This only affects the energy calculation and the transport of w by sedimenting hydrometeors, but regardless may give unexpected results. Lucas

…

On Fri, Apr 28, 2023 at 3:19 PM Oliver Elbert ***@***.***> wrote: When running without inline microphysics the GFS layer initializes the microphysics by creating a Statein and then passing Statein(1)%dycore_hydrostatic to gfdl_cld_mp_init. The problem with this is that Statein%dycore_hydrostatic is set to .true.` by default and isn't overwritten with the actual model configuration before initializing the microphysics: https://github.com/NOAA-GFDL/SHiELD_physics/blob/b285c9d05bda69ea7ee877b46edcd5ce28d31b92/GFS_layer/GFS_driver.F90#L221 https://github.com/NOAA-GFDL/SHiELD_physics/blob/b285c9d05bda69ea7ee877b46edcd5ce28d31b92/GFS_layer/GFS_typedefs.F90#L1361 This causes the parameters such as c_air to be set to their hydrostatic values instead of their nonhydrostatic values, and overrides do_sedi_w with .false. regardless of what is in the namelist. — Reply to this email directly, view it on GitHub <#20>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUQRVC5ZLESQLWUNY2BSJLXDQJ2XANCNFSM6AAAAAAXPTVDNE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

I think this was fixed by #26.