Unit Tests for Bugs Fixed in the Half Half PR
youralien opened this issue · 0 comments
youralien commented
From a previous PR, we should capture these changes and make sure these fixes are guarded by tests.
Fixes to Cerebro Server:
- Progressor [progressor.js] now imports methods like
notify
andadminUpdates
[progressorHelpers.js] which were being called in this file, but were failing before here. Now, people are notified after an experience is finished (notify
) and people's participation now is recorded in the appropriate places (adminUpdates
)
Suggested Test Cases:
it('should notify all participants after experience has ended')
// covered by end-to-end test
it('should remove the incident from active incidents in users profile')
// covered by end-to-end test
it('should add the incident to past incidents in users profile')
// ??? - not sure about current functionality
it('should remove the uid from the availability for that incident, since they are not eligible after participating')
it('should remove the uid from the assignment for that incident')
it('should set users profile to last participated to pretty recently')