Neargye/semver

Limitation to `std::uint8_t` might yield an overflow for some projects

daixtrose opened this issue · 7 comments

daixtrose commented

Checking the semver rules I am unsure whether a limitation to a value range from 0..255 (i.e. a limitation to std::uint8_t) is

  1. required and
  2. a wise design decision, especially for the patch number

Could you please explain your design decision?

Neargye commented

This limitation will be removed in the new version(0.4.0), there will be full support for semver.

  • 👍1
Danielmelody commented

Better to provide an template parameter for custom data precision

JaiganeshKumaran commented

This limitation will be removed in the new version(0.4.0), there will be full support for semver.

I reälly need this. Can you do this now?

Neargye commented

@JaiganeshKumaran now it's std::uint16_t

JaiganeshKumaran commented

Okay, but the vcpkg has not been updated yet. Also, you have not changed the version number in recent commits.

daixtrose commented

@JaiganeshKumaran you are aware this is an Open Source project for which you did not pay?