Netvent/storyly-sdk

iOS storyGroupAnimation

Closed this issue · 1 comments

Issue tracker is ONLY used suggestions.

storyGroupAnimation is now a String.
Values admitted are "borderAnimation" and "disabled".

No mention about it on inline documentation.
/** * This property allows you to change the animation of the story group */ @objc @IBInspectable final public var storyGroupAnimation: String

Suggestion 1:
add admitted values also in inline documentation or add the link to the documentation.
I found some info about ´storyGroupAnimation´ here:
https://docs.storyly.io/docs/ios-set-up-storyly-bar#story-group-animation

but none here:
https://integration.storyly.io/ios/ui-customizations.html#story-group-text-styling

Why do you use two different documentations?

Suggestion 2:
Create an enum

enum StoryGroupAnimationType {
case borderAnimation
case disabled
}

create a wrapper if you have to use it in obj-c. ;-)

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.