OCA/oca-addons-repo-template

[Regression] 17.0 : new pre-commit doesn't fix incorrect pylint errors

Closed this issue · 1 comments

legalsylvain commented

Since #219 has been merged.
CC : @yajo, @sbidoul, @pedrobaeza

Step to reproduce in v16 :

the black check fixes automatically errors.

pre-commit log :

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted attachment_queue/models/attachment_queue.py

All done! ✨ 🍰 ✨
1 file reformatted, 350 files left unchanged.

git log :

git status
Sur la branche 16.0-TEST-pre-commit
Modifications qui ne seront pas validées :
  (utilisez "git add <fichier>..." pour mettre à jour ce qui sera validé)
  (utilisez "git restore <fichier>..." pour annuler les modifications dans le répertoire de travail)
	modifié :         attachment_queue/models/attachment_queue.py

->>> OK.

Step to reproduce in v17 :

pre-commit log

ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

base_exception/__manifest__.py:14:89: E501 Line too long (94 > 88)
base_exception/models/base_exception.py:58:89: E501 Line too long (99 > 88)
base_exception/models/base_exception.py:60:89: E501 Line too long (89 > 88)
base_view_inheritance_extension/tests/test_base_view_inheritance_extension.py:36:89: E501 Line too long (93 > 88)
database_cleanup/models/purge_data.py:81:89: E501 Line too long (90 > 88)
module_change_auto_install/patch.py:73:89: E501 Line too long (99 > 88)
module_change_auto_install/patch.py:79:89: E501 Line too long (90 > 88)
Found 7 errors.

git log:

git status
Sur la branche 17.0-ocabot-update-dotfiles
Votre branche est à jour avec 'OCA/17.0-ocabot-update-dotfiles'.

rien à valider, la copie de travail est propre

->>>> KO. python files are not fixed.

Point of view

I didn't followed the switch from black to ruff and i don't work on V17 serie, so it's the first time I use ruff. At a first sight, I think it's a regression that should fixed. It's a pity if developpers or OCA maintainers have to fix manually such trivial errors that can be done predictivly by an algorithm.

Thanks for your feedback.

legalsylvain commented

Sorry for the noice.
It is about splitting strings. Black and ruff can not do it automatically.

  • 👍2