OHDSI/Arachne

Upload analysis zip not working when it contains execution-config.json file

Closed this issue · 5 comments

When I upload a zip file that contains a file execution-config.json the upload seems to not work. When I remove that json file it does work.

I'm using the latest release of arachne and execution engine

Steps to reproduce:

Create a new folder called test-execution-config

In that folder put an R script called main.R that contains one line of R code print('it works')

Also add a json file called execution-config.json with the following content

{
    "analysisName": "Simvastatin",
    "analysisType": "CUSTOM",
    "runtimeEnvironmentName": "Darwin Runtime",
    "dockerRuntimeEnvironmentImage": "executionengine.azurecr.io/darwin-base:v0.3" 
    "entryPoint": "test-execution-config/main.R",
    "studyName": "My study"
}

zip the folder an upload it to Arachne as a new analysis.

I see that the application does not respond at all. There is no error or message.

image

Expected behavior:
Fields should be auto populated with the values in the json file. If there is a problem with the format of the execution config file then some kind of message or instructions should be shown to the user describing how to fix the problem.

zip the folder an upload it to Arachne as a new analysis.

It's supposed that metadata file is place in the root of archive, not in subfolder

I tried using github. Here is the example code. You can try downloading this repo and uploading it to Arachne. https://github.com/ablack3/ArachneTest-execution-config

ArachneTest-execution-config-main.zip
@SergeySukhanov The metadata is not populated as expected

The problem is in formatting.
image
We need to handle and inform about errors in metadata files.

Resolved in #99