OctoD/godot-gameplay-systems

๐Ÿ› [bug]

AntonioJose-OcachoGames opened this issue ยท 3 comments

Describe the bug
User cannot use the has_tag function from an Ability Container because ability_container.gd doesn't have that function. It throws a runtime error when attempting to use it.

To Reproduce

  1. Add an Ability Container to a CharacterBody2D or CharacterBody3D.
  2. Add some tags to the Ability Container.
  3. Open the script attached to the character.
  4. Take a reference from the ability container: @onready var ability_container: AbilityContainer = $AbilityContainer
  5. Try to use the function has_tag from the Ability Container --> if not ability_container.has_tag("dead"):

Expected behavior
The has_tag function should return true or false if the tag is contained in the tags of the specified Ability in the Ability Container.

Screenshots
image

image

Desktop (please complete the following information):

  • OS: Windows 11
  • Godot 4.0.2

Additional context
Thank you for developing the addon :)
I found this issue following the tutorial. I don't know if the has_tag function should be added to the ability_container.gd file or if I should use the has_some_tags function from ability.gd.

OctoD commented

This bug is due to my incomplete testing. I'll fix in a matter of minutes, thank you for reporting and sorry for the inconvenience.

OctoD commented

Fixed in upstream, will be available on asset store as soon as Godot's team will review it.

Thank you for reporting!

Great! And no worries, we are here to help :)
Thank you!