FINAL TEMPLATE CHECKLIST
ryanpitts opened this issue · 24 comments
- beep
- kissane
Article detail #22
example 1 example 2
- beep
- kissane
- beep
- kissane
Article list by tag #70
example
- beep
- kissane
- beep
- kissane
Community landing page #50
example
- beep
- kissane
- beep
- kissane
Person detail #37
example 1 example 2
- beep
- kissane
- beep
- kissane
Organization detail #62
example
- beep
- kissane
Code list
example
- beep
- kissane
Code list by tag
example
- beep
- kissane
Code detail #36
example 1 example 2
- beep
- kissane
Jobs list
example
- beep
- kissane
Guide list
example
- beep
- kissane
Guide detail
example 1 example 2
- beep
- kissane
- beep
- kissane
Submit Guide form
example
- beep
- kissane
Submit Article form #87
example
- beep
- kissane
anything else?
@ryanpitts This is tremendously helpful, thank you! I’ll start working through this in the morning.
OK, I think this list captures everything.
This is incredible, thank you @ryanpitts
@ryanpitts Shall I start closing things that are double-checked above?
I think I have checked off everything that’s implemented!
(@ryanpitts, you are uhmazing.)
@beep @kissane I just updated the "Code list" and "Code list by tag" entries in the checklist. One thing re: "Code list by tag" -- it seems like we might need some affordance for backing back up a level once someone has drilled down. Like if you click on the "python" tag and get this, what do you do to back up to the main "Code" page? (This situation will also pop up in article tag lists)
Would make the Code lead a link, it occurs to me. We'll probably find a few of these kinds of things this week that we need to sort out, but @beep says he'll reply to our emails if we get stuck. 🙏🏻
heck yes he will
probably just a style that keeps links inside .page-title-lead the same dark gray, then?
I like this
OK, I don't think we have feedback threads for these, but these are ready for checkoff I believe:
- Guides list page: https://opennews-source-staging.herokuapp.com/guides/
- Guides detail page: https://opennews-source-staging.herokuapp.com/guides/defending-accounts/ & https://opennews-source-staging.herokuapp.com/guides/news-apps-essentials/
The guide_detail template is currently not doing anything with the cover image that shows up on the list page ... and I think I actually prefer that? Pulls you right into the articles, which likely have promo images of their own.
Guide list page is perfect, checked.
Guides detail page is gorgeous and my only questions are whether we should stick the curator's bio down underneath the whole thing, and whether the 3rd party credits I see exist in the CMS are hooked up to display on the site. (I added some in the CMS, but of course that doesn't hit staging.)
OK, pushed that fix, bio to the bottom of page. (Plus checked 3rd party credits): https://opennews-source-staging.herokuapp.com/guides/defending-accounts/
THX RYAN
can close anytime!
awesome, I'll check you off on those two pages above!
They should be all checked! Maybe my checking didn't take
@kissane new updates to check:
- Suggest a guide form: https://opennews-source-staging.herokuapp.com/guides/suggest/
- Jobs list: https://opennews-source-staging.herokuapp.com/jobs/
- Search results: https://opennews-source-staging.herokuapp.com/search/?q=propublica
- Suggest article: https://opennews-source-staging.herokuapp.com/articles/suggest/
OMG THAT'S ALL OF THEM
there are a few unchecked things here. shall I leave this open, or move things to separate issues?
yis!