Origen-SDK/origen

Can we remove Ruby 2.2 dependencies from app generators?

info-rchitect opened this issue · 6 comments

info-rchitect commented

Hi,

This line causes issues with newer gems:

gem 'byebug', '<9.1.0' # This version restriction required if you need Ruby < 2.2, otherwise you can remove it

Can we remove this from the app generator code? We don't support Ruby 2.2 in our Github builds so no need to keep it around right?

thx

pderouen commented

I vote that our app generator not cause dependency issues out of the shoot. I think we're recommending Ruby >=2.6 now aren't we?

ginty commented

No issue from me to change this, as long as it stays compatible with Ruby 2.5 (our min supported version) out the box.

info-rchitect commented

How would we really test this besides origen test?

ginty commented

We probably don't have to, we're moving in step with Ruby and it's community in terms of our minimum supported version.
So we can safely assume that an unspecified version of Byebug will resolve to something that works.

As an aside, I just moved O2 onto Github Actions instead of Travis for CI and its much simpler to setup. It wouldn't be hard to setup an automated test on GA that would build a new app and make sure it boots.

I can give a quick overview of GA at the next core team.

  • 👍1
priyavadan commented

@info-rchitect can we close this issue ?

  • 👍1