Ortham/libloadorder

Use not equal comparsion for timestamps

Ortham opened this issue · 1 comments

Currently timetamp comparisons check if the file timetamp is newer than the cached timestamp, but it is possible for the timestamp of a file to be changed so that it is older, as identified by @Utumno in wrye-bash/wrye-bash#195.

The simplest fix for this is to use a not equals comparison operator rather than a greater than operator.

Re-opening this as I think there may be a problem with the fix implemented.

One timestamp is stored, and it is set to the timestamp of the last file written, but it's possible for the plugin folder to have an older timestamp if the last file was written a second or more after the last plugin directory change.

Checking for changes in such a situation will therefore see a plugin folder that has a different timestamp and so will see it as having changed since the last save. I need to think how to turn this into a test...