Weird input into vfile

Question

Weird input into vfile

Quaker762 opened this issue 8 years ago · 3 comments

I'm getting weird values in the color palette of sys_konami.tex (section pic.arc, directory offset 0xE10, file offset 0x56C3E80). For some reason it's adding a few values of 0x0D in there? I'm not sure if this is due to the vfile buffer, or whether the problem lies in sh3_arc::LoadFile

Here's the problem, I'm stumped as to why this is happening..

I can confirm that Dump2Disk() isn't the issue, as the palette I'm dumping also contains the rogue values.

Answer 1 · 2017-02-17T13:34:03.000Z

Are you certain it's not Dump2Disk()? It looks like out_file should be opened in binary mode (std::ios_base::binary).
How are you dumping the palette?

Answer 2 · 2017-02-18T05:45:46.000Z

It looks like out_file should be opened in binary mode (std::ios_base::binary).

It looks like that was what was causing the bytes to be inserted in both the palette and Dump2Disk(). What causes the ofstream to insert these bytes when it isn't opened as binary??

Answer 3 · 2017-02-18T07:06:50.000Z

Well, this is exactly what opening a file without the binary flag does. It converts the plain newline character to the system's newline, which on Windows includes a carriage return character.

…

On February 18, 2017 6:45:46 AM GMT+01:00, Jesse ***@***.***> wrote: > It looks like out_file should be opened in binary mode (std::ios_base::binary). It looks like that was what was causing the bytes to be inserted in both the palette and `Dump2Disk()`. What causes the `ofstream` to insert these bytes when it isn't opened as binary??