Identical Legion Jewel .bin files get re-generated every single run
dsnvwlmnt opened this issue · 3 comments
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Is your feature request related to a problem?
Every time you launch PoB with a build that contains a Legion Jewel, e.g. /Data/TimelessJewelData/GloriousVanity.bin gets overwritten with the same file (same hash).
I'm using up transfer and disk space quotas with 4GB of identical file versions of GloriousVanity.bin.
Describe the solution you'd like
Add a check: If (LegionJewelsX-Y-Z).bin exist, don't re-generate.
Describe alternatives you've considered
If identical legion jewel .bin files must be generated repeatedly for reasons I'm unaware of, please generate it in the system TEMP location, compare the hash, and replace the original only if it is in fact different.
Alternately, if the purpose is to save 30 MB of space by compressing<>uncompressing these .bin<>.zip: leave them as .bin from the outset. The space is minuscule compared to GB upon GB of duplicate data generation.
Add a check: If (LegionJewelsX-Y-Z).bin exist, don't re-generate.
it checks that its still valid https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/src/Modules/DataLegionLookUpTableHelper.lua#L8-L77, likely an issue with your file system thats causing a false positive, though it should replace the file so shouldnt eat disk space (just write cycles)?, an explanation of the system you are running PoB on might help as it doesnt seem like the normal desktop usecase.
edit, looks like there might be an issue with a Roaming install, will update if we findout more, but info on your system will help