PennyLaneAI/pennylane-lightning

Unable to build from pypi source tarball

marcodelapierre opened this issue · 2 comments

marcodelapierre commented

Hi there,

while I was working on a Spack recipe for PennyLane and PennyLane-Lightning, I have noticed two small issues:

  1. the tarball from pypi does not contain CMakeLists.txt, hence the build fails; I resorted to using the github tarball for now
  2. CMake is not documented as source build dependency for PennyLane-Lightning; it might be useful for users to have it explicitly mentioned for this special type of builds.

For reference my Spack PR: spack/spack#34838

AmintorDusko commented

Thank you for reporting this issue @marcodelapierre.
We will definitely look into this.

mlxd commented

Hi @marcodelapierre thanks for reporting this. Just an FYI, there was some prior work started on adding Spack support back last year, but we never opened a PR due to additional commitments needed to complete this (https://github.com/mlxd/spack/tree/pennylane_lightning)

I'll try to take a look at your PR later this week, and see if we need to combine anything from my branch onto yours for this.

  • 👍1