Eslint

Question

Eslint

Closed this issue 7 years ago · 5 comments

As stated in issue #17, eslint should be added. I nominate using the Airbnb style guide. The code already seems to follow it closely. Any thoughts?

Answer 1 · 2018-02-11T02:40:27.000Z

yeah that's fine with me

…

On Sun, Feb 11, 2018 at 1:23 PM, Jam Risser ***@***.***> wrote: As stated in issue #17 <#17>, eslint should be added. I nominate using the Airbnb style guide. The code already seems to follow it closely. Any thoughts? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#23>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALMBlq525bJF1XnzzQ8XSMZO1ib3sLvUks5tTk8mgaJpZM4SBK7N> .

Answer 2 · 2018-02-11T17:57:36.000Z

I disabled the following airbnb rules.

no-plusplus
new-cap
global-require

Answer 3 · 2018-02-11T21:42:37.000Z

Any reason to disable no-cap? Thats a pretty standard rule.

…

On Mon, 12 Feb 2018 at 4:57 am, Jam Risser ***@***.***> wrote: I disabled the following airbnb rules. no-plusplus <https://eslint.org/docs/rules/no-plusplus> new-cap <https://eslint.org/docs/rules/new-cap> global-require <https://eslint.org/docs/rules/global-require> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALMBlshAYbVI4-7aQbGw1Nl83TyY_0XRks5tTyoQgaJpZM4SBK7N> .

Answer 4 · 2018-02-11T23:07:04.000Z

Yes, there are classes coming from gobject that are not lowercase. I'm not exactly sure why. I can look into it further, but for now, the best temporary solution is to disable new-cap.

I could disable it with a comment if you want?

Answer 5 · 2018-02-12T01:46:49.000Z

Nah that’s fine. We can always tighten it up later.

…

On Mon, 12 Feb 2018 at 10:07 am, Jam Risser ***@***.***> wrote: Yes, there are classes coming from gobject that are not lowercase. I'm not exactly sure why. I can look into it further, but for now, the best temporary solution is to disable new-cap. I could disable it with a comment if you want? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALMBlsoshcXtnEOqr3Bzu93YBoTo85viks5tT3KYgaJpZM4SBK7N> .