PlotJuggler/plotjuggler-ros-plugins

PJ won't build on melodic

elgarbe opened this issue · 6 comments

I follow instructions How to compile PlotJuggler from source
and got this error on catkin build:

elgarbe@notebook:~/ws_plotjuggler$ catkin build
-----------------------------------------------------------------
Profile:                     default
Extending:             [env] /opt/ros/melodic
Workspace:                   /home/elgarbe/ws_plotjuggler
-----------------------------------------------------------------
Build Space:        [exists] /home/elgarbe/ws_plotjuggler/build
Devel Space:        [exists] /home/elgarbe/ws_plotjuggler/devel
Install Space:      [unused] /home/elgarbe/ws_plotjuggler/install
Log Space:         [missing] /home/elgarbe/ws_plotjuggler/logs
Source Space:       [exists] /home/elgarbe/ws_plotjuggler/src
DESTDIR:            [unused] None
-----------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        None
-----------------------------------------------------------------
Additional CMake Args:       None
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
-----------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
-----------------------------------------------------------------
Workspace configuration appears valid.
-----------------------------------------------------------------
[build] Found '3' packages in 0.0 seconds.                                     
[build] Updating package table.                                                
Warning: generated devel space setup files have been deleted.
[build] Warning: Skipping package `plotjuggler_msgs` because it has an unsupported package build type: `ament_cmake`
[build] Note: Available build types:                                           
[build]  - `catkin`                                                            
[build]  - `cmake`                                                             
Abandoned <<< plotjuggler_ros                      [ Depends on unknown jobs: plotjuggler_msgs ]
Starting  >>> catkin_tools_prebuild                                            
Finished  <<< catkin_tools_prebuild                [ 1.8 seconds ]             
Starting  >>> plotjuggler                                                      
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________
Warnings   << plotjuggler:cmake /home/elgarbe/ws_plotjuggler/logs/plotjuggler/build.cmake.000.log                                                                                                                                                                             
/opt/ros/melodic/include/usr/include
cd /home/elgarbe/ws_plotjuggler/build/plotjuggler; catkin build --get-env plotjuggler | catkin env -si  /usr/bin/cmake /home/elgarbe/ws_plotjuggler/src/PlotJuggler --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/elgarbe/ws_plotjuggler/devel/.private/plotjuggler -DCMAKE_INSTALL_PREFIX=/home/elgarbe/ws_plotjuggler/install; cd -
..............................................................................................................................................................................................................................................................................
______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________
Warnings   << plotjuggler:make /home/elgarbe/ws_plotjuggler/logs/plotjuggler/build.make.000.log                                                                                                                                                                               
/home/elgarbe/ws_plotjuggler/src/PlotJuggler/plotjuggler_base/include/PlotJuggler/dataloader_base.h:0: Note: No relevant classes found. No output generated.
/home/elgarbe/ws_plotjuggler/src/PlotJuggler/plotjuggler_plugins/DataLoadCSV/dataload_csv.ui: Warning: The name 'layoutWidget' (QWidget) is already in use, defaulting to 'layoutWidget1'.
/home/elgarbe/ws_plotjuggler/src/PlotJuggler/plotjuggler_plugins/ToolboxQuaternion/quaternion_to_rpy.ui: Warning: The name 'frame' (QFrame) is already in use, defaulting to 'frame1'.
cd /home/elgarbe/ws_plotjuggler/build/plotjuggler; catkin build --get-env plotjuggler | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..............................................................................................................................................................................................................................................................................
Finished  <<< plotjuggler                          [ 2 minutes and 54.4 seconds ]                                                                                                                                                                                             
[build] Summary: 2 of 3 packages succeeded.                                                                                                                                                                                                                                   
[build]   Ignored:   1 packages were skipped or are blacklisted.                                                                                                                                                                                                              
[build]   Warnings:  1 packages succeeded with warnings.                                                                                                                                                                                                                      
[build]   Abandoned: 1 packages were abandoned.                                                                                                                                                                                                                               
[build]   Failed:    None.                                                                                                                                                                                                                                                    
[build] Runtime: 2 minutes and 56.2 seconds total.  

This looks as an outdated version of plotjuggler_msgs.

Pull the latest from master and switch to branch development.

there is no development branch on https://github.com/PlotJuggler/plotjuggler_msgs/branches/all
please, don't close the issue until it is resolved.

Same issue here. Any fix yet?

I added this line to the export tags in package.xml and things seemed to work

<build_type condition="$ROS_VERSION == 1">catkin</build_type>

that works for me too, nice catch!
you should issue a pull request

I added this line to the export tags in package.xml and things seemed to work

<build_type condition="$ROS_VERSION == 1">catkin</build_type>

Yep, this line is missing from package.xml in the plotjuggler_msgs directory.