PointCloudLibrary/pcl2

PCL_SHARED_LIBS is always ON for Android

csukuangfj opened this issue · 3 comments

See the code

pcl2/CMakeLists.txt

Lines 22 to 29 in f89677f

# ---[ Android check
if (ANDROID_NDK)
set (PCL_SHARED_LIBS OFF)
message ("PCL shared libs on Android must be: ${PCL_SHARED_LIBS}")
endif()
include(${PCL_SOURCE_DIR}/cmake/pcl_options.cmake)

# Build shared libraries by default.
option(PCL_SHARED_LIBS "Build shared libraries." ON)

Because include(${PCL_SOURCE_DIR}/cmake/pcl_options.cmake)
is executed after set (PCL_SHARED_LIBS OFF), the statement
option(PCL_SHARED_LIBS "Build shared libraries." ON)
gives PCL_SHARED_LIBS a value ON regardless of the platform.

Hi, this repository is abandoned, please use https://github.com/PointCloudLibrary/pcl.

I didn't know that. Is it ok if we merge his PR and then archive the repo? That will prevent opening issues and PRs on it.

Sure, I don't mind merging that.