PowerDataHub/terraform-aws-airflow

Bump dependencies for Terraform v0.13.2

crypdick opened this issue · 5 comments

I downloaded the latest terraform and tried to terraform init, but the https://github.com/cloudposse/terraform-terraform-label.git repo dependency is pinned to ref=tags/0.4.0, which is incompatible with v0.13.X apparently.

Error: Unsupported Terraform Core version

  on .terraform/modules/airflow-cluster.airflow_labels/versions.tf line 2, in terraform:
   2:   required_version = "~> 0.12.0"

Module module.airflow-cluster.module.airflow_labels (from
git::https://github.com/cloudposse/terraform-terraform-label.git?ref=tags/0.4.0)
does not support Terraform version 0.13.2. To proceed, either choose another
supported Terraform version or update this version constraint. Version
constraints are normally set for good reason, so updating the constraint may
lead to other errors or unexpected behavior.


Error: Unsupported Terraform Core version

  on .terraform/modules/airflow-cluster.airflow_labels_scheduler/versions.tf line 2, in terraform:
   2:   required_version = "~> 0.12.0"

Module module.airflow-cluster.module.airflow_labels_scheduler (from
git::https://github.com/cloudposse/terraform-terraform-label.git?ref=tags/0.4.0)
does not support Terraform version 0.13.2. To proceed, either choose another
supported Terraform version or update this version constraint. Version
constraints are normally set for good reason, so updating the constraint may
lead to other errors or unexpected behavior.


Error: Unsupported Terraform Core version

  on .terraform/modules/airflow-cluster.airflow_labels_webserver/versions.tf line 2, in terraform:
   2:   required_version = "~> 0.12.0"

Module module.airflow-cluster.module.airflow_labels_webserver (from
git::https://github.com/cloudposse/terraform-terraform-label.git?ref=tags/0.4.0)
does not support Terraform version 0.13.2. To proceed, either choose another
supported Terraform version or update this version constraint. Version
constraints are normally set for good reason, so updating the constraint may
lead to other errors or unexpected behavior.


Error: Unsupported Terraform Core version

  on .terraform/modules/airflow-cluster.airflow_labels_worker/versions.tf line 2, in terraform:
   2:   required_version = "~> 0.12.0"

Module module.airflow-cluster.module.airflow_labels_worker (from
git::https://github.com/cloudposse/terraform-terraform-label.git?ref=tags/0.4.0)
does not support Terraform version 0.13.2. To proceed, either choose another
supported Terraform version or update this version constraint. Version
constraints are normally set for good reason, so updating the constraint may
lead to other errors or unexpected behavior.

same issue here!

hi @crypdick do you mind open up a PR for this?

Thanks

@edbizarro I wouldn't know where to get started, this is my first time using Terraform

@crypdick no problem, I asked because I'm a little short in time and i believe I won't be able to look at this for the next couple of weeks

rca0 commented

Hi there 🖖🏻

I liked this solution and I contributed to the terraform 0.13 version update

  • Upgraded pre-commit versions
  • Added storage autoscaling on RDS instance
  • I fixed expressions deprecated
Warning: Interpolation-only expressions are deprecated

  on ../../../../../../github/terraform-aws-airflow/main.tf line 202, in resource "aws_instance" "airflow_scheduler":
 202:   subnet_id              = coalesce("${var.instance_subnet_id}", tolist(data.aws_subnet_ids.all.ids)[0])

Terraform 0.11 and earlier required all non-constant expressions to be
provided via interpolation syntax, but this pattern is now deprecated. To
silence this warning, remove the "${ sequence from the start and the }"
sequence from the end of this expression, leaving just the inner expression.

Template interpolation syntax is still used to construct strings from
expressions when the template includes multiple interpolation sequences or a
mixture of literal strings and interpolations. This deprecation applies only
to templates that consist entirely of a single interpolation sequence.

(and one more similar warning elsewhere)

#41