[FEATURE] Enable full clang-tidy build in nightly build
Closed this issue · 0 comments
mgovers commented
Describe the feature request
After #736 / #735 , we have a Nightly build that allows running
- Resolve the permissions issue in the Nightly build cfr. https://github.com/PowerGridModel/power-grid-model/actions/runs/11051238009/workflow
- fix the call to
main.yml
in https://github.com/PowerGridModel/power-grid-model/blob/main/.github/workflows/nightly.yml#L19 by adding permissions (cfr. https://docs.github.com/en/actions/sharing-automations/reusing-workflows#access-and-permissions and https://docs.github.com/en/actions/sharing-automations/reusing-workflows#example-caller-workflow)
- fix the call to
- Resolve the concurrency issue between Nightly and clang-tidy and the main pipeline
- in
nightly.yml
, replace thegroup: ${{ github.workflow }}-${{ github.ref }}
(https://github.com/PowerGridModel/power-grid-model/blob/main/.github/workflows/nightly.yml#L14) withgroup: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
(or similar) - idem for all other pipelines
- in
- Re-enable the full clang-tidy build in the nightly, including the benchmark (cfr. https://github.com/PowerGridModel/power-grid-model/blob/main/.github/workflows/nightly.yml#L25)
- Fix the clang-tidy warnings on the tests + benchmark (manual run of the clang-tidy with all targets, cfr. https://github.com/PowerGridModel/power-grid-model/actions/runs/11050900826 )
- Add the status badge for the
Nightly
pipeline to the README.md (e.g. )