PowerShell/PowerShellStandard

Several properties missing from CmdletProvider

Jaykul opened this issue · 4 comments

Jaykul commented

At least the following properties are missing:

        public PSTransactionContext CurrentPSTransaction { get; }
        protected object DynamicParameters { get; }
        protected PSDriveInfo PSDriveInfo { get; }
        protected internal ProviderInfo ProviderInfo { get; }

The TransactionAvailable() method is still there, but there's no way I can see to get at the transaction

Jaykul commented

Without these, the P2F framework won't compile against PowerShellStandard.Library, and thus, SHiPS isn't using PowerShellStandard -- they are shipping TWO SEPARATE BINARY MODULES (one targeting a private 1.0.0-alpha9 nuget package of SMA for Windows) ...

I can live without the transactions stuff (although I don't think it makes sense to have the TransactionAvailable() method if they're not usable).

However, I am not sure if it's even possible to write a provider without the other properties, and they're there in the v3 library...

JamesWTruher commented

something must have gone seriously wrong with one of my last merges. If these are missing. I'm tracking down what happened.

Jaykul commented

This bug was associated with the PR we closed last week, @JamesWTruher -- so I think it's fixed now.
I'll check against beta 4 tomorrow.

JamesWTruher commented

@Jaykul I will also be removing the TransactionAvailable method in preview05, your arguments were persuasive, and we can always add it back.