Custom tuning menu not set properly
dantrueman opened this issue · 3 comments
dantrueman commented
When editing a pre-existing tuning, either via text or the keyboard slider, rather than setting the scale menu to "custom" it sets it to Grammateus.
mulshine commented
Ahh ok, can imagine how this happened. When we transitions from including
adaptive's in scale menu to having them be external. Have to always
add/subtract 2 from tuning depending on menu and I think Grammateus must be
two away from Custom in the list. So this case isn't handled. In long run,
would be cleaner to re-index the scales so they are continuous.
Also I could imagine "Custom" becoming unnecessary. It could be that
offsets are saved from the current chosen scale and applied to on that
scale, and "custom" offsets notes could be highlighted slightly differently
than ones that adhere to the offsets-from-ET of the selected scale. Just a
thought.
…On Tue, Jan 29, 2019 at 1:29 PM dantrueman ***@***.***> wrote:
When editing a pre-existing tuning, either via text or the keyboard
slider, rather than setting the scale menu to "custom" it sets it to
Grammateus.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#126>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AGlRgKwbyWAaLfw--gd3WP9cuwKaJ7tDks5vIJL2gaJpZM4aYqKQ>
.
dantrueman commented
ok, I think we should keep it as it is for now; can revisit when we dig into Scala and other tuning stuff in the future, when lots of other scales will be in the mix.
mulshine commented
fixed with setScaleByName()