`minecraft-data` should be in dependencies
ianpaschal opened this issue · 1 comments
ianpaschal commented
Right?
Now it's in devDependencies which looks like a mistake to me. I'm happy to make PR as its only a 1 minute change but I wanted to confirm beforehand.
rom1504 commented
Yeah we used to only depend on prismarine-block so it didn't need to be a
dep. Now it seems we are using it directly so it should be a dependency
indeed
…On Fri, Apr 24, 2020, 16:51 Ian Paschal ***@***.***> wrote:
Right?
Now it's in devDependencies which *looks* like a mistake to me. I'm happy
to make PR as its only a 1 minute change but I wanted to confirm beforehand.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#76>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR437RGYKTWWFKJSOFUL5DROGRNRANCNFSM4MQFFIEA>
.