ProAlgos/ProAlgos-Cpp

two algorthims fail -fsanitize = address

Opened this issue · 3 comments

pm100 commented

I turned on a bunch of gcc sanitizers

set(CMAKE_CXX_FLAGS "-g -O0 -Wall -Wextra -pedantic-errors -fsanitize=leak -fsanitize=address -fsanitize=undefined ")

This picked up the three leaking programs I reported before. Plus it detected

knuth_morris_pratt:
=================================================================
==26751==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000000d4 at pc 0x55f2698bd590 bp 0x7ffc0d266560 sp 0x7ffc0d266550

and

binary_search:
=================================================================
==26722==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000000d4 at pc 0x55972fefc2b9 bp 0x7ffe4cb4de70 sp 0x7ffe4cb4de60
stale commented

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

Thanks for reporting this! These sanitizers seem very helpful, I'll add them to the build process.

pm100 commented

i have pending fixes for these as well. Have been out of country for a while, hence the silence