A introduction of codebase is required
Closed this issue · 6 comments
shivankgtm commented
I was going through the code base and there were many points that I couldn't understand, I even tried going commit wise. we can deal with those particular questions also but in that case, we might miss some points.
A quick go through should be enough then if some issue occurs we can discuss them directly.
theSage21 commented
I'll write some documentation to help in obnboarding.
…On Sun 19 Apr, 2020, 02:58 Shivank Gautam, ***@***.***> wrote:
I was going through the code base and there were many points that I
couldn't understand, I even tried going commit wise. we can deal with those
particular questions also but in that case, we might miss some points.
A quick go through should be enough then if some issue occurs we can
discuss them directly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2WHUIV4KYHXE33BDX4UM3RNILPNANCNFSM4MLQM4ZA>
.
theSage21 commented
I've updated the README file with some info. If you still have questions we can get on a call and sort those out.
theSage21 commented
@shivank98 can we consider this done?
shivankgtm commented
let it be for some more time. I haven't gone through all of code-base yet. If something comes up we can discuss it here
theSage21 commented
Usually we just ask questions in the pr code changes even if the pr is
merged.
That way you can actually ask the person who wrote the code.
…On Tue 21 Apr, 2020, 15:41 Shivank Gautam, ***@***.***> wrote:
let it be for some more time. I haven't gone through all of code-base yet.
If something comes up we can discuss it here
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2WHUPAAAZYPX3KMRSA3L3RNVWMXANCNFSM4MLQM4ZA>
.
shivankgtm commented
Oh ok then.closing it.