PythonOT/POT

The example in the tutorial (Optimal Transport solvers comparison) does not work due to the NotImplementedError

Opened this issue · 1 comments

I tried the example in Optimal Transport solvers comparison (https://pythonot.github.io/auto_examples/plot_solve_variants.html#sphx-glr-auto-examples-plot-solve-variants-py)

It gave me NotImplementedError when defining G = ot.solve(M, a, b, **param).plan

NotImplementedError: Not implemented reg_type="KL" and unbalanced_type="tv"

By inspecting the code, it seems that many combinations are ignored in the implementation.

if not isinstance(reg_type, tuple) and reg_type.lower() in ['kl'] and unbalanced_type.lower() == 'kl':

Will that be included in future? Or does it exist in some branches?
(I installed via pip install POT[all], and it seems to installed POT-0.9.3-cp38-cp38-win_amd64.whl)

The ot solver comparisaon was introduced in 0.9.4 so your version is out of date. This isa goodfeedback we should probably add "Introduce in POT X.X.X" to the new examples in the documentation