Remove hard coded references to SOABM
Closed this issue · 2 comments
This code needs to be transferable to Metro and other areas. There are several places in the model setup where a reference to the geographical area of SOABM is hard-coded. There should be nothing hard coded about the specific region that the model is in. An example of this issue is in the name of the Visum connection script:
https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py
Another example is the Version file input (SOABM.ver), which is hard coded throughout this script.
This issue is to change the reference to the version file name to either have a version file pointer in the properties file or the bat file. Additionally the script name of “SOABM.py” would need to be changed to something like “ABM_PreProcessor.py”, and any other hard coded references to SOABM would need to be removed.
This will require specific changes in the user guide, but more generally, ODOT will be working to remove references to SOABM from the user guide to more generic ABM references where it can.
I would note that if ODOT is planning on moving to ActivitySim for the next ABM implementation, than this code update would have little value to ODOT. It might be useful to Metro so that they don't have to name everything SOABM... Although, that's only if Metro is planning on using Visum...
It just occurred to me that if we want to use SOABM.py for CALM, we need the SOABM.ver hard coded file references removed. So that a specific file name can be provided by the user that is model / application specific. I noted in my email to Binny today that this task might get scoped along with the Python 3.0 task #94. I was thinking that was optional, but now I think having this issue and #94 is a critical scoping piece.