Plan to use Rx5 instead of Rx4 due to breaking changes?

Question

Plan to use Rx5 instead of Rx4 due to breaking changes?

Opened this issue 9 years ago · 13 comments

tihuan commented 9 years ago

Since Rx5 introduces some breaking changes (link), I was wondering if rx.angular.js will eventually move to Rx5 too.

For example, rx.Observable.replay() is now rx.Observable.publishReplay() in Rx5.

P.S. I'm using rx.angular.js in an ng1.4.8 app :)

Thanks a lot!

Answer 1 · 2016-01-21T21:23:28.000Z

I know this is frowned upon, but +1.

Answer 2 · 2016-01-22T02:38:01.000Z

Hey @nmn! I'm still very new to RxJS, so could you elaborate on why this is frowned upon :)? Thanks a lot!

Answer 3 · 2016-01-22T03:46:40.000Z

@tihuan I was talking about the "+1" comments on github.

Answer 4 · 2016-01-22T17:46:52.000Z

@nmn Ahaha, I see! I didn't know that's a thing! TIL 🎅

Answer 5 · 2016-05-02T15:52:58.000Z

There are actually a bunch of api changes between rx 4 and 5 now: https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md

Answer 6 · 2016-06-01T19:35:19.000Z

I just created #146 which contains the changes to make rx.angular.js work with RxJS 5 (beta 8 - but I expect the changes will continue to work future betas as RxJS 5 closes on RC the incompatible changes should be fewer)

Answer 7 · 2016-06-01T19:44:51.000Z

Woohoo! Thanks for the fabulous work 💯 !

Answer 8 · 2016-06-02T12:30:09.000Z

You the man @awk!

Answer 9 · 2016-11-23T16:21:48.000Z

Is this still on the cards ?

Answer 10 · 2017-04-12T12:52:40.000Z

@mickdelaney I hope so!

Answer 11 · 2017-09-01T10:48:01.000Z

I need this too please!

Answer 12 · 2017-09-01T11:43:10.000Z

Rx5 with Angular 1 ?

note: There's some discussion on this issue in the PR #146

Answer 13 · 2017-09-01T11:47:31.000Z

I saw that one, should have paid more attention to it, thanks.