RenderKit/oidn

Support for ispc-1.18.1 planned?

Pro-pra opened this issue · 9 comments

Pro-pra commented

subj

Vertexwahn commented

@Pro-pra Do you see any specific problems when using ISPC 1.18.1 instead of ISPC 1.18.0? As far as I understand you only have to set ISPC_EXECUTABLE to the ISPC 1.18.1 binary and it should work.

atafra commented
Pro-pra commented

My build with ispc-1.18.1 fail with errors:

make[2]: Leaving directory '/builddir/build/BUILD/oidn-1.4.3/build'
stdlib.ispc:714:5: Error: Unable to find any matching overload for call to 
        function "__aos_to_soa2_float" only considering exact matches. 
        Passed types: (uniform float * uniform, varying float * uniform, 
        varying float * uniform) 
        
stdlib.ispc:717:73: Error: Unable to find any matching overload for call to 
        function "__soa_to_aos2_float" only considering exact matches. 
        Passed types: (varying float, varying float, uniform float * uniform) 
        
stdlib.ispc:721:5: Error: Unable to find any matching overload for call to 
        function "__aos_to_soa3_float" only considering exact matches. 
        Passed types: (uniform float * uniform, varying float * uniform, 
        varying float * uniform, varying float * uniform) 
        
stdlib.ispc:724:83: Error: Unable to find any matching overload for call to 
        function "__soa_to_aos3_float" only considering exact matches. 
        Passed types: (varying float, varying float, varying float, uniform 
        float * uniform) 
        
stdlib.ispc:728:5: Error: Unable to find any matching overload for call to 
        function "__aos_to_soa4_float" only considering exact matches. 
        Passed types: (uniform float * uniform, varying float * uniform, 
        varying float * uniform, varying float * uniform, varying float * 
        uniform) 
        
stdlib.ispc:732:5: Error: Unable to find any matching overload for call to 
        function "__soa_to_aos4_float" only considering exact matches. 
        Passed types: (varying float, varying float, varying float, varying 
        float, uniform float * uniform)
Pro-pra commented

Thank you!

atafra commented

Did you try ISPC 1.19? What's the latest version which still worked for you?

Pro-pra commented

need some time for testing, ispc not support llvm16, need recompile it with llvm15

Deleted user commented

If you need it today, you can try the bazel based build

https://github.com/Vertexwahn/rules_oidn

Pro-pra commented

Thank all, i build worked ispc-1.9.0 with llvm15 and oidn compiled fine!