Using the library in RP2040

Question

Using the library in RP2040

jotamachuca opened this issue 2 years ago · 25 comments

Hi !

I used your library with the RP2040 (Raspberry Pi Pico) . I used the earlephilhower board for my project.

For used your library in my project I make this changes in the I2c_eeprom.h and I2C_eeprom.cpp file

.h

#if defined (ESP8266) || defined(ESP32) ||defined(PICO_RP2040)
  //  set the I2C pins explicitly (overrule)
  bool     begin(uint8_t sda, uint8_t scl);
#endif

#ifdef PICO_RP2040
bool I2C_eeprom::begin(uint8_t sda, uint8_t scl)
{
   //  if (_wire == 0) Serial.println("zero");  //  test #48
  if ((sda < 255) && (scl < 255))
  {
    _wire->setSCL( scl );
    _wire->setSDA( sda);
    _wire->begin();
  }
  _lastWrite = 0;
  return isConnected();
}
#endif

I want to add this change in the actual branch. Can it ??

Thanks for your work !!

See you later

Answer 1 · 2023-05-02T09:31:21.000Z

Thanks for this addition,

You can make a PR, or have a little patience and I will do it later today.

Answer 2 · 2023-05-02T09:39:48.000Z

I propose I will do it as I have might have some minor edits I can include.
Expect a develop branch in 30 minutes.

Answer 3 · 2023-05-02T09:47:12.000Z

Nice !

I will wait and add this little addition :D

Answer 4 · 2023-05-02T10:03:27.000Z

FYI,
#54 Pull Request created, build is running.

Answer 5 · 2023-05-02T10:15:17.000Z

@jotamachuca
Build ran successfully, will merge it after lunch
You may download the develop branch and test it if you are in a hurry :)

Answer 6 · 2023-05-02T10:59:43.000Z

Did some minor edits,

Answer 7 · 2023-05-02T11:03:01.000Z

Merged develop branch into master, releasing 1.7.2
Thanks for the addition.

Answer 8 · 2023-05-02T12:08:57.000Z

@jotamachuca

I was porting your proposal for improved RP2040 support to the I2C_24LC1025 library and I noticed another possible improvement for the RP2040. Don't know if you need it.

I looked it up and the internal I2C buffer size of the RP2040 ==> 256 bytes

I2C_eeprom.cpp line 25-30

#if defined(ESP32) || defined(ESP8266)
#define I2C_BUFFERSIZE           128
#else
#define I2C_BUFFERSIZE           30   //  AVR, STM
#endif

==>

#if defined(ESP32) || defined(ESP8266) || defined(PICO_RP2040)
#define I2C_BUFFERSIZE           128
#else
#define I2C_BUFFERSIZE           30   //  AVR, STM
#endif

For EEPROM's the page size is at most 64 KB (afaik) so using bigger buffers will not increase performance (assumption).

Do you have time to see if it gives a performance gain?

I make a note of it so it will be in a next release (someday).

Answer 9 · 2023-05-02T12:14:25.000Z

(added the code in my local branch so it will automatically in the next release)

Answer 10 · 2023-05-02T12:23:29.000Z

I will check this mods this week :D

Answer 11 · 2023-05-07T18:04:11.000Z

Hi !!

I checked and all is ok :D

Answer 12 · 2023-05-07T18:17:29.000Z

Good to hear!

Answer 13 · 2023-05-09T21:08:18.000Z

@jotamachuca

Apparently your defined(PICO_RP2040) is not unique enough to be earlephilhower specific.
See #55

Answer 14 · 2023-05-09T21:16:07.000Z

@jotamachuca

Apparently your defined(PICO_RP2040) is not unique enough to be earlephilhower specific. See #55

Uff

I will check tomorrow what is the correct defined for the earlephilhower ....

Sorry for this mistake, but, for me, the library work without problems.

See you tomorrow!

Answer 15 · 2023-05-09T21:33:55.000Z

Thanks for the quick response!

Answer 16 · 2023-05-10T09:18:29.000Z

Created a develop branch with a patch that should repair the backwards compatibility.

You need to uncomment line 33 in I2C_EEPROM.h for now.
I have send a mail to earlephilhower to ask if his boards module has an unique define to fix this issue.

Please verify.

Answer 17 · 2023-05-10T09:49:18.000Z

Hi

I checked the code very fast and, I cannot found a define for earlephilhower core .....

I will write a email to check it

Sorry for it problem

Answer 18 · 2023-05-10T10:24:59.000Z

The line (33) you should uncomment in the develop branch is

I2C_EEEPROM.h

#define RP2040_PATCH_53             true

Answer 19 · 2023-05-10T10:26:43.000Z

The line (33) you should uncomment in the develop branch is

I2C_EEEPROM.h
#define RP2040_PATCH_53             true

Sure, but i want to find the define for the earlephilhower core.

Answer 20 · 2023-05-10T10:33:10.000Z

Sure, but i want to find the define for the earlephilhower core.

Searched his code and found many defines but none of them unique as far as I could see,
Therefor I decided to email him this morning, if such define exists.
In the mean time I patched with a pretty unique define to prevent breaking too much projects.

But if you find something, please let me know.

Answer 21 · 2023-05-10T10:35:03.000Z

Sure, but i want to find the define for the earlephilhower core.

Searched his code and found many defines but none of them unique as far as I could see, Therefor I decided to email him this morning, if such define exists. In the mean time I patched with a pretty unique define to prevent breaking too much projects.

But if you find something, please let me know.

Yes, i checked today in the morning, and i havent an unique define for used....

I will wait for the answer :D

See you later !!

Answer 22 · 2023-05-10T17:10:38.000Z

@jotamachuca

Got an answer and ARDUINO_ARCH_RP2040 was proposed.
As that is also used by the Arduino MBED , it is not unique enough, so investigation continues....

Answer 23 · 2023-05-10T17:21:12.000Z

An option is to combine ARDUINO_ARCH_RP2040 and ARDUINO_ARCH_MBED.

#if defined(ARDUINO_ARCH_RP2040) 
#if not defined(ARDUINO_ARCH_MBED)
  begin(sda, scl)     //  earlephilhower 
#endif
#endif

to be continued tomorrow.

Answer 24 · 2023-05-11T10:28:29.000Z

Merged and released 1.7.3 with better solution.

Answer 25 · 2023-05-11T10:45:29.000Z

I used the ARDUINO_ARCH_RP2040 and all ok :D