Robosturm/Commander_Wars

AW4 CO Mod Lin's Power Should Only Give Vision and Hiding Place Vision to Ground Units

FruityGumGuiltyFruit opened this issue · 2 comments

Describe the bug
In actual AW4, only Lin's ground units gain the extra vision and ability to see into hiding places.

To Reproduce
Steps to reproduce the behavior:

  1. Activate AWDC CO Mod
  2. Use Lin's power in fog of war map.
  3. See error

Expected behavior
Only her ground units should get the extra vision and ability to see into hiding places.

Screenshots
Screenshot 2024-03-26 120636
image
image
image
image
image

Desktop (please complete the following information):

  • OS: [Windows 10 Home]
  • Version [22h2]
  • Active Mods (AWDC CO Mod)
  • Game Version [Latest 0.36.2-main]

Additional Context
I don't know how difficult it would be to fix for the vision into hiding places, since I think you need to add a variable to check unit, but this.getPerfectVision = function(co, map) doesn't have support for unit.
var seaAirUnit = (unit.getUnitType() === GameEnums.UnitType_Air) || (unit.getUnitType() === GameEnums.UnitType_Naval);

if (!seaAirUnit) { return true; }

Perfect vision won't be changed/fixed.

Just going to throw this out there.
Lin's power descriptions should be changed to reflect this change
This is what they are right now (for both COP and SCOP):
Lin's ground units gain +%2% firepower and +%2% defence. Her other units gain +%3% firepower and +%4% defence. All of her units gain +%0 vision and can see into hidden locations.
This is what they should be (to reflect this change)
Lin's ground units gain +%2% firepower, +%2% defence, and +%0 vision. Her other units gain +%3% firepower and +%4% defence. All of her units can see into hidden locations.