RvSpectML/EchelleCCFs.jl

Issues

• check if documentation for struct is accurate

  #62 opened 2 years ago by hematthi
  1

• `num_chunks(clt)` should be the same as `norders`

  #74 opened 2 years ago by hematthi
  2

• early return to save time? Also the type of the output would be different ('Nothing')

  #95 opened 2 years ago by hematthi
  0

• if intended to index `x` in steps of 2i, should check that `length(ifo.x) = 2*length(info.gw)`?

  #88 opened 2 years ago by hematthi
  1

• unknown type `FuncT` in struct

  #86 opened 2 years ago by hematthi
  1

• check if `psf_width` is correct (or address TODOs)?

  #94 opened 2 years ago by hematthi
  1

• dangerous assertion?

  #53 opened 2 years ago by hematthi
  3

• check if `calc_length_ccf_v_grid` is doing what is intended (see Issue #52)

  #56 opened 2 years ago by hematthi
  2

• `calc_ccf_v_grid(plan)` function does not do what the docstring says

  #52 opened 2 years ago by hematthi
  0

• function sometimes uses `length(plan.line_list)` and sometimes uses `length(plan.line_list.λ)`

  #59 opened 2 years ago by hematthi
  1

• should `σ_new` be multiplied by `sqrt(2)` or is it already included?

  #91 opened 2 years ago by hematthi
  0

• output assigned to `ccf_var` could be a 1d or 2d array

  #57 opened 2 years ago by hematthi
  1

• `fits_hdr` optional argument is overwritten anyway in function

  #79 opened 2 years ago by hematthi
  0

• assert on an array of values

  #80 opened 2 years ago by hematthi
  0

• `v_offset` and `σ_sqrt2` should be fields of `m`

  #85 opened 2 years ago by hematthi
  0

• cannot pass named tuples into `fieldtypes()`?

  #77 opened 2 years ago by hematthi
  2

• `in` argument of type `MeasureRvFromCCFTemplateNonDiagCovar` does not have `frac_of_width_to_fit` and `measure_width_at_frac_depth` fields

  #48 opened 2 years ago by hematthi
  1

• `num_chunks` not defined in function

  #66 opened 2 years ago by hematthi
  1

• default value for `plan_for_chunk` optional argument does not match type

  #72 opened 2 years ago by hematthi
  3

• check if `n1` = 0/1 for even/odd or vice versa

  #89 opened 2 years ago by hematthi
  2

• not all `alg` functors have implementations for all four versions of `measure_rv_from_ccf`

  #47 opened 2 years ago by hematthi
  1

• add `v_center_to_avoid_tellurics` to documentation and check sign convention (address TODO)

  #97 opened 2 years ago by hematthi
  0

• update documentation (e.g. replace `depth` with `weight`)

  #96 opened 2 years ago by hematthi
  0

• Update documentation to be accurate and address TODOs

  #93 opened 2 years ago by hematthi
  1

• remove old/commented code

  #92 opened 2 years ago by hematthi
  0

• address TODOs?

  #90 opened 2 years ago by hematthi
  0

• add documentation for functions

  #87 opened 2 years ago by hematthi
  0

• update documentation (and function to actually allow for a mixture of Gaussians)

  #84 opened 2 years ago by hematthi
  0

• update docstring for inner constructor

  #83 opened 2 years ago by hematthi
  1

• use `boost_factor` (address TODO)

  #82 opened 2 years ago by hematthi
  0

• remove commented/moved code and add documentation to remaining function

  #81 opened 2 years ago by hematthi
  0

• add documentation and warnings for default values (address TODO)

  #78 opened 2 years ago by hematthi
  2

• repetitive large blocks of code can be made into separate function

  #76 opened 2 years ago by hematthi
  1

• potentially redundant print statements?

  #69 opened 2 years ago by hematthi
  2

• can use `nobs` instead of `length(clt)`

  #75 opened 2 years ago by hematthi
  1

• update documentation to consistently describe and name all arguments

  #71 opened 2 years ago by hematthi
  5

• should probably check size of `chunk_ccf_vars_out` too

  #73 opened 2 years ago by hematthi
  0

• `calc_ccf_covar` and `calc_ccf_var` can both be true in if-elseif condition

  #70 opened 2 years ago by hematthi
  0

• update documentation to describe and consistently name all arguments

  #65 opened 2 years ago by hematthi
  6

• should `num_vels` be the maximum or the first of the lengths of each ccf plan?

  #68 opened 2 years ago by hematthi
  0

• length of `chunk_list` or `chunk_list.data`?

  #67 opened 2 years ago by hematthi
  0

• function seems redundant with `calc_ccf_chunk()` with `calc_ccf_var = True`

  #64 opened 2 years ago by hematthi
  0

• update documentation to describe and consistently name all arguments (`plan` instead of `ccf_plan`; `var`)

  #63 opened 2 years ago by hematthi
  3

• improve documentation to describe different versions (e.g. `ccf_vars`) and all arguments

  #61 opened 2 years ago by hematthi
  0

• const default parameters also defined in `EchelleCCFs` module

  #60 opened 2 years ago by hematthi
  0

• improve documentation for large function

  #58 opened 2 years ago by hematthi
  0

• asserts redundant due to type declarations for `λ` and `flux`

  #51 opened 2 years ago by hematthi
  5

• update documentation to include all arguments

  #50 opened 2 years ago by hematthi
  3

• (not an issue)

  #55 opened 2 years ago by hematthi
  1

• could add assert at beginning of function to also check length of `var`

  #54 opened 2 years ago by hematthi
  0