SEL-Columbia/pybamboo

Make tests less fragile with mocking or waiting via polling

Opened this issue · 3 comments

pld commented

The tests are very fragille. Some of the calls to bamboo.io can be mocked, I start using mock in bamboo, it's very helpful.

For that do call we can poll the status for some things, i.e. pending state of datasets and calculations. Updates have an internal pending marker that the bamboo API should expose, once that's exposed can also poll on updates.

thinking we should do this soon, though i think that we should leave an option to run against an actual server since we will inevitably make mistakes with mocking the bamboo API or keeping it up to date. also, it takes forever to run the tests so it will speed up the dev process to have this in place. would be awesome if we could have a spec file that sort of defines the bamboo API in terms of requests/data and responses. maybe even keep it up to date in bamboo...

In my last email on Nigeria, had asked Renaud (on pybamboo side) +
Dickson/Larry (on bamboo.js side) to work on this (making the requests/data
a fixtures repo somehwere). Partially my fault, haven't had a chance to
connect with them all week, will do so on Friday finally.

On Wed, Feb 20, 2013 at 4:55 PM, Mark Johnston notifications@github.comwrote:

thinking we should do this soon, though i think that we should leave an
option to run against an actual server since we will inevitably make
mistakes with mocking the bamboo API or keeping it up to date. also, it
takes forever to run the tests so it will speed up the dev process to have
this in place. would be awesome if we could have a spec file that sort of
defines the bamboo API in terms of requests/data and responses. maybe even
keep it up to date in bamboo...


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-13859114.

Prabhas Pokharel
http://twitter.com/prabhasp
US mobile: +1 347 948 7654
skype/facebook/whatever: prabhasp

pld commented

Strongly support having this an option so you can also run against the bamboo server. It's a great way to test bamboo!