SPL-ethz/snow

Rewrite python code to use model-10

Closed this issue · 9 comments

ltdeck commented

Marco and I discussed this when finalizing the methods section for the manuscript. He agrees that model-8 / model-10 are equivalent, so no action required.

bizzinho commented

The math result is not exactly the same, tho?

bizzinho commented

And the implementation here does not match the paper or do I misremember?

bizzinho commented

So will you do this @ltdeck ?

ltdeck commented

I would consider it as an addition, i.e. we provide the user with the option to select one of the two approaches. After all, the models are equivalent, i.e. no one is more correct than the other from a theoretical point of view, and the mathematical results differ by less than 0.1% in the initial amount of ice formed, i.e. solidification times differ by around 0.01%. Will discuss this in the comment. I agree with you, that we should set the standard option to the one described in the methods.

bizzinho commented

@ltdeck , need to actually add that code for model-10 as well into snowflake.py line 522 ;)

ltdeck commented

@bizzinho , I know. Have it on my to-do list. Thanks for the reminders ;)

ltdeck commented

@bizzinho I added it and did a validation of a box of vials, for which I found close agreement between the two methods. I wrote a few pages on this and added it to the validation file on overleaf. Please have a look.

bizzinho commented

Note for myself: d8cc4da