STAMP-project/pitmp-maven-plugin

skip modules doesn't work

yilativs opened this issue · 4 comments

Characteristics

  • Issue Type: [bug]
  • Reproducibility: [always]
  • Severity: [block]
  • Tool/Service/Component: [1.3.6]
  • Execution Environment: [java8, linux]
  • Reporter: [Vitaliy]

Description

It is unclear from documentation, how to properly specify skippedModules
(I tried all possible options) and none seems to work.
in order to exclude foo-module1 I've tried both maven2 and maven3 style params, groupId:artifactId and module name

foo-module1 org.foo:foo-module1 foo-module1 org.foo:foo-module1

Steps to reproduce

git clone https://github.com/yilativs/pitmp-multi-module-sample.git
cd pitmp-multi-module-sample
mvn eu.stamp-project:pitmp-maven-plugin:run

expected result: foo-module1 is skipped
result: plugin runs pit mutations for foo-module1

I tried with the command line:
mvn "-DskippedModules=foo-module1" eu.stamp-project:pitmp-maven-plugin:run
and it workded.
So I add a look in the pom.xml and I think the problem comes from the duplicated tags <configuration>...</configuration>.
I replaced:
image
with:
image
and it worked.
Let me know if it works for you too. :-)

command line paramet skipModules works but changing configuration does not.

I've added a sample for you https://github.com/yilativs/pitmp-multi-module-sample/tree/skip-via-param-tag

executing:
mvn package -DskipTests eu.stamp-project:pitmp-maven-plugin:run
will fail build because module 1 tests will be executed ( i intentionally added a test there that will fail)

executing:
mvn package -DskipTests
won't fail, because tests will be skipped because of a bag either in configruation
or in maven plugin

executing:
mvn "-DskippedModules=foo-module1" eu.stamp-project:pitmp-maven-plugin:run
works, skippedModuled parameter works

There's still duplicated marks in the file pom.xml :-)

		<configuration>
			<configuration>          <!-- DUPLICATED -->
				<skippedModules>
					<param>foo-module1</param>
				</skippedModules>
				...
			</configuration>         <!-- DUPLICATED -->
		</configuration>

Remove those 2 lines from the pom.xml:

I tried it and it works with both and tags to specify the required module to be skipped.
This wasn't a bug but my misconfiguration.
Thank you very much for support!