SalOne22/rimage

[Bug]: The `-q` option doesn't take effect for jpegxl

Closed this issue · 4 comments

Is there an existing issue for this?

  • I have searched the existing issues

Description

-q/--quality doesn't make any difference when combined with -f jpegxl.

  • OS: Debian 12 for WSL.

Expected behavior

generating images of varying quality with -q/--quality

Library Version

0.9.1 (latest)

Steps To Reproduce

No response

Anything else?

No response

The -q opinion is disabled on release v0.10.0 when you choose the jxl format.

The current implementation of the -q (quality) flag in rimage can be somewhat unclear, especially since some codecs, like jpegxl, do not support lossy compression. To address this, in the upcoming major release, I am planning to introduce a more versatile API. This new API will offer distinct options tailored to each codec, ensuring clearer and more effective control over the compression and quality settings for different image formats.

The current implementation of the -q (quality) flag in rimage can be somewhat unclear, especially since some codecs, like jpegxl, do not support lossy compression. To address this, in the upcoming major release, I am planning to introduce a more versatile API. This new API will offer distinct options tailored to each codec, ensuring clearer and more effective control over the compression and quality settings for different image formats.

That would indeed make it clearer. The reason I was confused is that when comparing jpegxl and avif, I found that jpegxl supports both lossy and lossless encoding, but it didn't seem to work during testing.

Resolved in #188