3.3 release breaks existing custom modules that worked w/3.2.1
rjledger opened this issue · 8 comments
Getting a strange error in Firebug (Error: Tried to register widget with id==configure_quickactions but that id is already registered).
I even pulled all except one simple one (parent add-on) and still no joy.
Can you try removing this.inherited(arguments); from loadViews and loadCustomizations in your ApplicationModule.js?
The problem is our sample module incorrectly uses this.inherited. The only module that should be calling this.inherited is our based application module. Other customization modules are loaded in side by side through the modules array (you can see this in configuration/development.js). Before it was OK, because the SDK didn't add any of it's own views. Now it does, and each loaded module is trying to call into the base, it looks like this:
argos-saleslogix\src\ApplicationModule::loadViews -> calls this.inherited which invokes argos-sdk\src\ApplicationModule::loadViews
argos-sample\src\ApplicationModule::loadViews -> calls this.inherited which also invokes argos-sdk\src\ApplicationModule::loadViews
We can probably put in a flag at the SDK level so it won't execute twice, if an application module incorrectly invokes this.inherited.
Tried – no diff.
RJLedger – www.rjlsystems.nethttp://www.rjlsystems.net/
Blog: www.rjlsystems.net/blog.html
Office: +1 603.369.3047 x101
Direct (DID): +1 603.369.4987
From: Jason Best [mailto:notifications@github.com]
Sent: Wednesday, May 13, 2015 18:08
To: Saleslogix/argos-saleslogix
Cc: Robert Ledger
Subject: Re: [argos-saleslogix] 3.3 release breaks existing custom modules that worked w/3.2.1 (#346)
Can you try removing this.inherited(arguments); from loadViews and loadCustomizations in your ApplicationModule.js?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/346#issuecomment-101831344.
Try the commit I just referenced: Saleslogix/argos-sdk@3415e4b
Just hacked it in. Most working but I’m seeing one custom not quite working. It’s the “parent” one. It’s right out of the sample as an individual (custom) module and deployed like the rest thru the “AA”. It’s sitting there saying loading… for the parent value.
AH - it is throwing an error related to dojo:
dojo.removeclass is not a function
I see where you changed it in the sample - making the same change.
Have you guys run in the sample and tested all of it?
rj
RJLedger – www.rjlsystems.nethttp://www.rjlsystems.net/
Blog: www.rjlsystems.net/blog.html
Office: +1 603.369.3047 x101
Direct (DID): +1 603.369.4987
From: Jason Best [mailto:notifications@github.com]
Sent: Wednesday, May 13, 2015 18:29
To: Saleslogix/argos-saleslogix
Cc: Robert Ledger
Subject: Re: [argos-saleslogix] 3.3 release breaks existing custom modules that worked w/3.2.1 (#346)
Try the commit I just referenced: Saleslogix/argos-sdk@3415e4bhttps://github.com/Saleslogix/argos-sdk/commit/3415e4b30f657fa27c38f63518af409230ddfc95
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/346#issuecomment-101837810.
I will go thru a full regression test of all my custom modules and post results.
All modules working.
Thanks for the feedback.