Selenium 4.0.1-alpha.79-windows: playback window position
Opened this issue · 13 comments
🐛 Bug Report
-
The playback windows opens some pixels up and left of the reserved space in the main window
-
After a test is played, the playback window does not move when main windows is moved.
To Reproduce
Steps to reproduce the behavior:
- open a project
- play a test (the playback window is some pixelds up and left of its expected place)
- after the test is played, move the main window (the playback window stays in its initial place)
Expected behavior
The playback window should stick to the reserved place (where the "This is where recording and playback will occur" text is shown).
Environment
OS: Windows 10
Selenium IDE Version:4.0.1-alpha.79-windows
@BartolomeSintes - Thank you for reporting! I was scared of this being off on other platforms when I set it up initially. I'm adding a handler for the 'move' event in electron. It appears on Mac OS it treats move as a resize as well, so I was getting more for free there. Will likely still be off by a bit in x.80, but should at least move with the project window.
@coinzdude - Sorry to ask your help here, but are you also seeing this offset here on the playback windows? I want to make sure its just a windows thing (can detect platform and tack on an offset) and not a something-else-thing.
The obvious workaround until this behavior is corrected is to close the playback window (ctrl+p), move the main window and restart the test.
@BartolomeSintes - I tried to add a bunch around this thing for this version. There should be screen dimension controls in the top-right. They deal with overriding window size for a number of reasons. If playback window is larger than panel, it should instead do this by zooming out. If smaller, it will crop down. 🤞 hopefully it feels good
Version going out in just a bit
Alright, x.80 is live, and doubles down on playback panel controls. It could still probably use some improving, and that initial offset might still be there on windows (maybe it needs to calculate for menubar and stuff still or something idk) but it's on its way.
The offset of the playback window seems to be independent of the window size. If you could move the playback window 12px to the right and 21px to the bottom, I think it would be OK. Then, the panel controls would be visible.
In x.80 the playback window moves with the main window, but resizing does not work as it should. If the main window grows in size, the playback window grows accordingly, but if the main window reduces its size, the playback window maintains its size.
This also happens on Ubuntu 22.04 (Wayland)
4.0.1-alpha.79-linux
elp here, but are you also seeing this offset here on the playback windows? I want to make sure its just a windows thing (can detect platform and tack
@toddtarsi On windows, I see this in 80. My script uses set window size, say 1600x1080 and it appears playback initially is trying to best fit that window by scaling like so:
but, once I begin to resize the underlying window, this resizing starts to "creep" the playback window outside of its 'bounding box'.
It otherwise is doing a pretty decent job of trying to hang that playback content to the main window, this is after dragging around, reducing, minimize/maximize
@coinzdude - Thanks for the corroboration! I've got a branch locally thats got a few of these issues tee'd up, but I want to take a bit of the weekend and try to get electron-updater into it, so hopefully using the releases means no more re-installing on windows.
@beerwin - Thanks for corroborating as well! I think I have this fixed locally (just using more electron events to detect this: move + moved / resize + resized vs just moved and resized)
@BartolomeSintes @beerwin @coinzdude - A fix for this should be going out. I applied the recommended offset for the win32 platform (12x21 I believe), and I attached two more listeners for resizing / moving, so hopefully I'm picking up all interactions on windows now. Sorry it's been taking me a minute on this last release, I have a pretty big changeset and I just want to make sure it feels good.
In alpha 97 the position has improved, but it is still a little bit up and right from the due position. I would say that the playback window should open 6px left and 3px down from the present position.
These are two screenshots of the top left and bottom left corners of the playback window. I have added a red rectangle 6px wide and 3px high in both images.
alpha 98 shows the playback window like in alpha 97.
@BartolomeSintes - Will be putting out beta.2 shortly, which will adjust the offset by (-6, 3)