Shardj/zf1-future

iconv() Null Deprecation

Closed this issue · 3 comments

kiatng commented 
[type] => 8192:E_DEPRECATED
[message] => iconv(): Passing null to parameter #3 ($string) of type string is deprecated
[file] => .../shardj/zf1-future/library/Zend/Pdf/Resource/Font/Simple.php

zf1-future/library/Zend/Pdf/Resource/Font/Simple.php

Line 268 in f8018da

return iconv($charEncoding, 'CP1252//IGNORE', $string);

sreichel commented

Can you track down, where it comes from? Maybe its easier to fix inside OpenMage?

sreichel commented

Nice. IMHO this can be closed.

(@kiatng o/c it could be also fixed here, but im a fan of simple as possible method signatures ... just assume strict types allowing only string arguments)

kiatng commented

Fixing here would make it easier for the dependents of zf1-future to upgrade to PHP8 or 9. But OK, it's the responsibility of the dependents and their plugins to fix all null deprecations.