Order of distinct and top is wrong

Question

muuvmuuv opened this issue 7 months ago · 5 comments

When using both, distinct will come after "top 20" which results in an SQL error.

Answer 1 · 2024-05-28T15:36:38.000Z

Fix:

$sql = preg_replace('/^SELECT(\s+DISTINCT)?\s/i', 'SELECT$1 TOP ' . $count . ' ', $sql);

In shardj/zf1-future/library/Zend/Db/Adapter/Sqlsrv.php:618

Answer 2 · 2024-10-15T17:01:22.000Z

Anyone to create PR and test locally?

Answer 3 · 2024-10-15T18:55:29.000Z

Does it have or need tests? We have it in production at one customer and no issues since i vreated the ticket so far

Answer 4 · 2024-10-15T19:30:32.000Z

If it's already proven, then just create an PR pls.