Data_Download acting up again

Question

Data_Download acting up again

Closed this issue 6 years ago · 11 comments

Since a few days, afte ra longer mldata downtime (i think it still down):

101/145 Test #101: Data_Download ...........................................***Failed 152.63 sec
Running 3 test cases...
/home/travis/build/Shark-ML/Shark/Test/Data/Download.cpp(40): error in "Data_Download_URL": Got exception [download] http protocol violation
/home/travis/build/Shark-ML/Shark/Test/Data/Download.cpp(63): error in "Data_Download_MLData": Got exception [download] http protocol violation
*** 2 failures detected in test suite "ML_Download"

how good is a binding to a webpage that is always down?

TGlas commented 6 years ago

done.

Answer 1 · 2018-07-07T06:15:55.000Z

mldata.org does not seem to be well-maintained already for years. The simplest solution is to link to our self-hosted data used in the "hello world" tutorial at http://www.shark-ml.org/data/quickstart-train.csv.

Answer 2 · 2018-07-07T06:35:17.000Z

should we remove the mldata download facility? just use the url download?

…

________________________________ From: Tobias Glasmachers [notifications@github.com] Sent: Saturday, July 07, 2018 8:15 AM To: Shark-ML/Shark Cc: Oswin Krause; Author Subject: Re: [Shark-ML/Shark] Data_Download acting up again (#239) mldata.org does not seem to be well-maintained already for years. The simplest solution is to link to our self-hosted data used in the "hello world" tutorial at <http://www.shark-ml.org/data/quickstart-train.csv> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#239 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOWTBhvxnZSIkW2AiVmj_Fp46IfHYcGVks5uEFIcgaJpZM4VGO7R>.

Answer 3 · 2018-07-07T09:11:05.000Z

Let remove mldata.

Answer 4 · 2018-07-07T09:12:21.000Z

A different issue is that we only support http, not https. This will be an increasing issue in the future. That would cost us an openssl dependency, which could be optional. Would you consider that worth the hassle?

Answer 5 · 2018-07-07T09:17:58.000Z

i hav a tendency towards "no". I think this function is only relevant for the first steps to get started smoothly. but nothing relevant.

…

________________________________ From: Tobias Glasmachers [notifications@github.com] Sent: Saturday, July 07, 2018 11:12 AM To: Shark-ML/Shark Cc: Oswin Krause; Author Subject: Re: [Shark-ML/Shark] Data_Download acting up again (#239) A different issue is that we only support http, not https. This will be an increasing issue in the future. That would cost us an openssl dependency, which could be optional. Would you consider that worth the hassle? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#239 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOWTBj2KBl0uEUwgXnwVS8V562WYIV2Uks5uEHt2gaJpZM4VGO7R>.

Answer 6 · 2018-07-07T16:36:49.000Z

If we remove mldata.org support, then we could also remove support for the HDF5 data set format. As far as I know, mldata is the only platform that pushed the format, and as far as I can tell it was not widely adopted.

Answer 7 · 2018-07-07T17:39:40.000Z

mldata support removed, docs, tests and examples updated accordingly

Answer 8 · 2018-07-07T19:03:37.000Z

Fully agreed. Kill it. Also remove scoped handle from core

…

________________________________________ From: Tobias Glasmachers [notifications@github.com] Sent: Saturday, July 07, 2018 6:36 PM To: Shark-ML/Shark Cc: Oswin Krause; Author Subject: Re: [Shark-ML/Shark] Data_Download acting up again (#239) If we remove mldata.org support, then we could also remove support for the HDF5 data set format. As far as I know, mldata is the only platform that pushed the format, and as far as I can tell it was not widely adopted. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#239 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOWTBoJSH8ZIhJQG4b0qOYAYadBTChneks5uEOOigaJpZM4VGO7R>.

Answer 9 · 2018-07-08T04:18:12.000Z

Just to be sure: "Fully agreed. Kill it." refers to HDF5 support, not to my short post above?

Answer 10 · 2018-07-08T07:43:45.000Z

yes. kill hdf5 support

…

________________________________ From: Tobias Glasmachers [notifications@github.com] Sent: Sunday, July 08, 2018 6:18 AM To: Shark-ML/Shark Cc: Oswin Krause; Author Subject: Re: [Shark-ML/Shark] Data_Download acting up again (#239) Just to be sure: "Fully agreed. Kill it." refers to HDF5 support, not to my short post above? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#239 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOWTBplJQtVeoSzGOMGOAirAXG8sFQVsks5uEYgGgaJpZM4VGO7R>.