Shopify/tapioca

`ActiveRecord::TypedStore` DSL compiler does not respect `array: true` for columns

ipvalverde opened this issue · 2 comments

ipvalverde commented

If you're using the ActiveRecord::TypedStore gem (reference) and set a column as being array: true, the generated rbi will not respect the array indication. Example:

class Shop < ActiveRecord::Base
  typed_store :settings do |s|
    s.string(:tags, array: true, default: [], null: false)
  end
end

### Generated RBI:

class Shop
  module StoreAccessors
    sig { returns(String) }
    def tags; end

    # ...
  end
end

The expected would be to have the columns that are defined as array to have their type wrapped in a T::Array type. So for the example above, I would expect the output to be:

class Shop
  module StoreAccessors
    sig { returns(T::Array[String]) }
    def tags; end

    # ...
  end
end
andyw8 commented

Related: #1217

amomchilov commented

Just confirming, the array: true attribute is already available in-memory, so can make use of that in our compiler, without needing to hook the .string method.

https://github.com/byroot/activerecord-typedstore/blob/2f3fb98e6506d4d97113e5d817264c22bf9837da/lib/active_record/typed_store/field.rb#L14

It should be accessible on the field, here:

tapioca/lib/tapioca/dsl/compilers/active_record_typed_store.rb

Line 100 in 6e37d44

field = store_data.fields.fetch(accessor)

  • 👍1