Send section problem

Question

Send section problem

AxeelAnder opened this issue 6 years ago · 6 comments

If a section is very complicated, it's size will overflow the buffer. Clients recieved the broken tiles data and throw an exception, it causes the section can't be shown correctly.
This bug only exists in modified server, vanilla server works well.
Expand the buffer can solve it as I tried.

Answer 1 · 2018-10-20T05:52:47.000Z

This happens in a vanilla OTAPI server, or a TSAPI/OTAPI/Mintaka mix?

On Fri, Oct 19, 2018 at 22:49 Axeel ***@***.***> wrote: If a section is very complicated, it's size will overflow the buffer. Clients recieved the broken tiles data and throw an exception, it causes the section can't be shown correctly. *This bug only exists in modified server, vanilla server works well.* Expand the buffer can solve it as I tried. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAggp4Z40ZDaTFeVUtxPjsUI2dQd79ihks5umrlKgaJpZM4Xxvmd> .

-- Lucas Nicodemus http://keybase.io/xn

Answer 2 · 2018-10-20T05:57:35.000Z

This happens in a vanilla OTAPI server, or a TSAPI/OTAPI/Mintaka mix?
On Fri, Oct 19, 2018 at 22:49 Axeel @.***> wrote: If a section is very complicated, it's size will overflow the buffer. Clients recieved the broken tiles data and throw an exception, it causes the section can't be shown correctly. This bug only exists in modified server, vanilla server works well. Expand the buffer can solve it as I tried. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAggp4Z40ZDaTFeVUtxPjsUI2dQd79ihks5umrlKgaJpZM4Xxvmd .
-- Lucas Nicodemus http://keybase.io/xn

happens in both

Answer 3 · 2018-10-20T06:04:16.000Z

it's easy to write a patch to fix it, but idk the appropriate size

Answer 4 · 2018-10-20T06:17:19.000Z

If you have a WIP patch just send a PR and yolo it, someone else can step in and tune it. Lucas Nicodemus http://keybase.io/xn

…

On Fri, Oct 19, 2018 at 11:04 PM Axeel ***@***.***> wrote: it's easy to write a patch to fix it, but idk the appropriate size — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAggp9usel5jJh64iFlwDFceKZLFhrgYks5umrzkgaJpZM4Xxvmd> .

Answer 5 · 2018-10-20T06:22:53.000Z

Also @AxeelAnder sign up for https://hacktoberfest.digitalocean.com first so you can get a shirt

Answer 6 · 2018-10-22T07:41:05.000Z

Technical difficulties commenting on the PR, so this is what I was trying to say:

@AxeelAnder Basically if it's not a problem in vanilla and it can be replicated using stock OTAPI then it should be an OTAPI fix rather than TShock. However that fix is probably best suited for TShock, and if the guys are happy for that go nuts.

I had a quick look and I don't think that buffer is actually required with a bit more modification work, e.g. directly write the data from within NetMessage.CompressTileBlock by passing down the BinaryWriter from NetMessage.SendData; or similarly by redirecting the CompressTileBlock call in SendData to a OTAPI version so it can be done via C# instead of patching.
Though as fun as this sounds I don't have the time to do this so your fix should work fine via TShocks' config.