AWS codeploy validate.sh improvement
roneigebert opened this issue · 4 comments
roneigebert commented
The generated validate.sh file waits a fixed time (it can be changed - parameter on pom.xml) to validate if the service started. I think it can be improved:
Current appspec.yml
validate service step timeout: 3600 seconds
Current validate.sh
sleep [fixed time|default 10 seconds]
if [service if not up]{
raise error
}
Desired appspec.yml
validate service step timeout: [fixed time|default 10 seconds]
Desired validate.sh
while [service is not UP]{
sleep 1 second
}
miere commented
It definitely makes sense, mate. And it's quite easy to address.
Mind to send us a PR?
…On Wed, Nov 13, 2019 at 9:47 AM Ronei ***@***.***> wrote:
The generated validate.sh file waits a fixed time (it can be changed -
parameter on pom.xml) to validate if the service started. I think it can be
improved:
*Current appspec.yml*
validate service step timeout: 3600 seconds
*Current validate.sh*
sleep [fixed time|default 10 seconds]
if [service if not up]{
raise error
}
*Desired appspec.yml*
validate service step timeout: [fixed time|default 10 seconds]
*Desired validate.sh*
while [service is not UP]{
sleep 1 second
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#268?email_source=notifications&email_token=AAD7NUHHJ636W7BPFHGZ6ITQTMW6LA5CNFSM4JMKEEF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HY2YLBQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7NUGW5YPMGM4HB6SGHQLQTMW6LANCNFSM4JMKEEFQ>
.
miere commented
Any thoughts on this, mate?
roneigebert commented
Sorry for my delay @miere. Yesterday we talked about it here (Ibratan, @jardelnovaes).. We want to send a PR soon
roneigebert commented