Cross-platform repository directory names

Question

Cross-platform repository directory names

Opened this issue 4 years ago · 6 comments

Super minor nits to consider:

Replace spaces in the repository's directory names with underscores.
Ensure that the directory names are cross-platform (e.g., stick to ASCII characters if possible).
Remove hyphens, commas, apostrophes, parentheses, and other punctuation from directory names.
Use at most one period in directory and file names.
Delete old directories if they are no longer used (let the repository handle archival).

I was informed that some repo directory names are not handled well by Windows. For example:

Variable Extension - optical and width/Nathan Wilis /NathanWillis Merriweather--Cyrillic-lc-upright.glyphs

The extra space at the end of the directory name, Nathan Wilis , could pose a problem on Windows, for example. Highly recommend normalizing the directory names.

Answer 1 · 2020-09-17T05:02:38.000Z

Thanks! I am pretty new to Git repos and still have plenty to learn. I am expecting a bump in the version to be pushed next week btw. Best!

…

-e.

On Thu, Sep 17, 2020 at 12:04 AM Dave Jarvis ***@***.***> wrote: Super minor nits to consider: - Replace spaces in the repository's directory names with underscores. - Ensure that the directory names are cross-platform (e.g., stick to ASCII characters if possible). - Remove hyphens, commas, apostrophes, parentheses, and other punctuation from directory names. - Use at most one period in directory and file names. - Delete old directories if they are no longer used (let the repository handle archival). I was informed that some repo directory names are not handled well by Windows. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#514>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQUQXLVEKDXMNTAEZ724NDSGGDEDANCNFSM4RPZMSEA> .

Answer 2 · 2020-09-18T02:23:08.000Z

I have a fix for this issue, but cannot push it.

Answer 3 · 2020-09-18T03:08:36.000Z

Isn't a pull request the normal way to fix?

Answer 4 · 2020-09-18T03:10:16.000Z

Also, I will fix this after I consult with the client (Google) about it because although there may be a Github standard way to do this there may also be a Google Fonts standard way and in candor the later will win if they are opposed.

Answer 5 · 2020-09-18T04:12:08.000Z

A pull request certainly is the normal way to provide you with the fix. To create a pull request, I first need permission to push to your repository.

Dave and I are software developers. By all means, feel free to consult with Google, but we work with Git repositories for a living. If Google has an opinion, they are going to prefer best practices and conventions that are cross-platform compatible.

The fix is quite simple. Not all operating systems allow trailing space characters in folder and file names. The path:
Variable Extension - optical and width/Nathan Wilis (with the trailing space) prevents the entire repository from being cloned onto a Windows machine. Just do a rename on that folder to delete the trailing space.

My primary interest in this issue is being able to clone the repository onto a Windows machine, which I cannot do at the moment.

Answer 6 · 2020-09-18T13:05:23.000Z

To create a pull request, I first need permission to push to your repository.

You should also be able to fork the repository (https://github.com/SorkinType/Merriweather/fork) to your own account, make changes there, then open a pull request to this repository.