cleanup commit b2e914742abf26f5ea20e7437fbbe81a1df595b0
Closed this issue · 1 comments
jonaspleyer commented
Commit b2e9147 introduced the covariance matrix to the calculation.
Some parts of the changes should be rethough/dropped:
- pool_model_make_plots.py had inserted some more comments. This should be dropped
- src/solving.py now calculates the relative error with 25% which is not desired since it can not be adjusted from outside in any form. Also: how could we possibly supply a absolute error or avoid computing the covariance matrix. I can see that relative error calculation is desired but the current implementation should be generalized.
- pool_model.py got an empty line commited. Drop that change.
polinagaindrik commented