SpikeHimself/XPortal

Portal occasionally forgetting destination

Opened this issue · 0 comments

mischab1 commented

The last portal you set the destination for sometimes forgets it's destination between closing and reopening the world. More likely to happen if you open a 2nd world between the two.

Below are the notes about portals forgetting destinations copied from the comments of Issue #72.
However, 9 times out of 10, if I start with no portals connected to any other portal and then daisy-chain them, 1 -> 2 -> 3 and then logout; open a different world; don't do anything; log out of that world and back into my test world, it's forgotten the last link in the daisy chain.

Bug found when testing debug-v1,2,18-issue72-01
I've tested this with 3 portals and with 4. Link 1 to 2 and then go thru the portal; link 2 to 3 and go thru the portal; link 3 to 4 and go thru the portal. Log out, open different world, log out, re-open this world. Run back over to where portal 3 is and it's no longer linked to portal 4. If portal 4 was already linked to another portal when portal 3 was linked to it, this doesn't happen.

LogOutput.log
Above is my last log from yesterday. I was testing a bunch of different ways to link portals some that worked and some that didn't. I'll try to do a new test just showing the issue this evening after work.

LogOutput file
Here is a shorter log with 3 tests. My test world has 4 portals named p1 thru p4. I reset all of them to none before starting this test.
LogOutput.log

To Reproduce
Start modded valheim with:

  • BenInExPack_Valheim v5.4.2200
  • Jotunn v2.14.4
  • Official_BepInEx_ConfigurationManager v18.0.1
  • XPortal debug v1.2.18

Test 1

  1. open world TestXPortal
  2. connect portal p1 to portal p2, go thru portal
  3. connect portal p2 to portal p3, go thru portal
  4. logout of world
  5. open a different world and close it
  6. reopen world TestXPortal
  7. p2 lost connection to p3

Test 2

  1. walk back to portal p2 and re-connect it to p3, go thru portal
  2. logout of world
  3. open a different world and close it
  4. reopen world TestXPortal
  5. p2 remembers connection to p3

Test3

  1. connect portal p3 to p4, go thru portal
  2. (The extra portal triggers are because I stepped thru p4 twice killing a Neck)
  3. logout of world
  4. open a different world and close it
  5. reopen world TestXPortal
  6. p3 forgot p4
  7. quit valheim

Environment
Steam version of Valheim via Thunderstore 1.32.2. worlds are saved to cloud. Playing Singleplayer

Other mods

  • BenInExPack_Valheim v5.4.2200
  • Jotunn v2.14.4
  • Official_BepInEx_ConfigurationManager v18.0.1

Priority
Low (XPortal is still working fine, but sometimes a thing goes wrong)