StanfordAHA/lassen

add w/ external carry feature dropped?

Closed this issue · 2 comments

Right now the carry in for the normal add op is always set to 0 (see https://github.com/StanfordAHA/lassen/blob/master/lassen/sim.py#L60). IIRC jade set the cin using a one-bit input (see https://github.com/StanfordAHA/CGRAGenerator/blob/master/hardware/generator_z/pe_new/pe/rtl/test_pe_comp.svp#L507) which enables the construction of a carry chain adder (e.g. for a 32 bit add).

Did we intend to drop this feature?

I think we should add it back in. Ill do a PR

Fixed by #86